Fix all Lean build warnings

- Update deprecated lemmas (ite_eq_left/right, ENat casts, List.Sublist, ...)
- Replace push_neg with push Not and resolve unused-variable warnings
- Convert flexible simp/simp_all calls to explicit simp only lists
- Remove unscoped maxHeartbeats options, open scoped Classical, and unused tactics
- Add missing module docstrings and clean up style linter hits
- Wrap over-long lines and flatten the deeply nested
  minimal_conflictRangeClosedForm_total proof

`lake build` now completes with zero warnings.
This commit is contained in:
andrew committed 2026-11-17 10:04:35 -05:00
1 parent a54a5f82f8
commit af318a7d32
51 files changed
+2542 -1357

No files matched your search

+10 -10
View File
@@ -82,8 +82,8 @@ theorem crossed_rev_res_ge_begin_general {db : DB} {r : RangeRead} {res : Result
keys at or above `end_.key`. -/
theorem crossed_rev_res_ge_end_general {db : DB} {r : RangeRead} {res : Result}
(hc : RangeRead.Compatible db r res)
(hrev : r.reverse = true) (hbegin : 1 ≤ r.begin.offset)
(hcross : r.end_.key < r.begin.key) (hend : 1 ≤ r.end_.offset) :
(_hrev : r.reverse = true) (hbegin : 1 ≤ r.begin.offset)
(hcross : r.end_.key < r.begin.key) (_hend : 1 ≤ r.end_.offset) :
∀ k ∈ res.keys, r.end_.key ≤ (k : WithTop Key) := by
intro k hk
have hge := crossed_rev_res_ge_begin_general hc hbegin k hk
@@ -149,7 +149,7 @@ theorem sound_truncatedRevCrossed_top_general {r : RangeRead} {res : Result}
reversed truncated read, the complete keys are exactly the reported keys. -/
theorem completeKeys_eq_res_of_crossed_rev_finite_general {db : DB} {r : RangeRead}
{res : Result}
(hcomp : RangeRead.Compatible db r res) (hmore : res.more = true)
(hcomp : RangeRead.Compatible db r res) (_hmore : res.more = true)
(hrev : r.reverse = true) (hbegin : 1 ≤ r.begin.offset)
(hcross : r.end_.key < r.begin.key) (hend : 1 ≤ r.end_.offset)
(hne : res.keys ≠ [])
@@ -271,7 +271,7 @@ theorem crossed_rev_finite_above_filter_eq_take_general {db : DB} {r : RangeRead
/-- In the finite branch the gap `[end_.key, begin_.key)` stores no key. -/
theorem crossed_rev_finite_gap_eq_zero_general {db : DB} {r : RangeRead} {res : Result}
(hcomp : RangeRead.Compatible db r res) (hmore : res.more = true)
(hcomp : RangeRead.Compatible db r res) (_hmore : res.more = true)
(hrev : r.reverse = true) (hbegin : 1 ≤ r.begin.offset)
(hcross : r.end_.key < r.begin.key) (hend : 1 ≤ r.end_.offset)
(hne : res.keys ≠ [])
@@ -622,7 +622,7 @@ theorem crossed_rev_insert_between_incompatible_general {db : DB} {r : RangeRead
rw [hinskeys, hJeq, List.getElem?_insertIdx]
have hlt : ¬ j + 1 < db.keys.countP (fun x => decide (x < k)) := by omega
have heq : ¬ j + 1 = db.keys.countP (fun x => decide (x < k)) := by omega
rw [if_neg hlt, if_neg heq, Nat.add_sub_cancel, List.getElem?_eq_getElem hjlt, hjeq]
rw [ite_eq_right hlt, ite_eq_right heq, Nat.add_sub_cancel, List.getElem?_eq_getElem hjlt, hjeq]
obtain ⟨_, hnewget⟩ := List.getElem?_eq_some_iff.mp hnewget?
have hHresolve : resolve (db.insert k hk0) r.end_ = ((H : Key) : WithTop Key) := by
rw [resolve_eq_getElem (anchor_nonneg_of_one_le hend) hnewlen]
@@ -710,12 +710,12 @@ theorem crossed_rev_finite_last_lookup_general {db : DB} {r : RangeRead} {res :
have hgoal? : lE[b]? = some (res.keys.getLast hne) := by
rw [hdecomp]
rw [List.getElem?_append]
rw [if_pos (by
rw [ite_eq_left (by
rw [List.length_append, hP_len, List.length_reverse]
have htpos : 0 < res.keys.length := List.length_pos_of_ne_nil hne
omega)]
rw [List.getElem?_append]
rw [if_neg (by rw [hP_len]; omega)]
rw [ite_eq_right (by rw [hP_len]; omega)]
have hidx : b - (lE.take b).length = 0 := by rw [hP_len]; omega
rw [hidx]
have hpos : 0 < res.keys.length := List.length_pos_of_ne_nil hne
@@ -731,7 +731,7 @@ theorem crossed_rev_finite_last_lookup_general {db : DB} {r : RangeRead} {res :
/-- Erasing `k` from the database removes it from the keys at or above `E` when it was
there. -/
theorem above_erase_of_mem (db : DB) (E : WithTop Key) {k : Key}
(hk : k ∈ above db E) : above (db.erase k) E = (above db E).erase k := by
(_hk : k ∈ above db E) : above (db.erase k) E = (above db E).erase k := by
rw [above_eq_filter, above_eq_filter, DB.erase_keys, ← List.erase_filter]
/-- Erasing `k` from `[E, B)` removes it from the erased database's gap. -/
@@ -777,7 +777,7 @@ theorem crossed_rev_finite_mem_take_of_lt_last_general {db : DB} {r : RangeRead}
/-- In the finite crossed reversed branch, erasing a reported key makes the result
incompatible. -/
theorem crossed_rev_erase_reported_incompatible_general {db : DB} {r : RangeRead}
{res : Result} {k : Key} (hcomp : RangeRead.Compatible db r res)
{res : Result} {k : Key} (_hcomp : RangeRead.Compatible db r res)
(hk : k ∈ res.keys) :
¬ RangeRead.Compatible (db.erase k) r res := by
intro hc
@@ -819,7 +819,7 @@ theorem crossed_rev_finite_erase_pad_incompatible_general {db : DB} {r : RangeRe
have hcountErase : (lE.erase k).countP (fun x : Key => decide (x < L)) = b - 1 := by
rw [List.countP_erase, hcount]
have hcond : k ∈ lE ∧ decide (k < L) = true := ⟨hklE, by simp [hklt]⟩
rw [if_pos hcond]
rw [ite_eq_left hcond]
have hLmemErase : L ∈ lE.erase k := by
have hLmem : L ∈ lE := hLlookup' ▸ List.getElem_mem hbL
exact (List.mem_erase_of_ne (ne_of_gt hklt)).mpr hLmem