From 2d3e7b9004e98255164b842ea6a07022ad53ccbd Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Wed, 3 Apr 2024 12:19:55 -0700
Subject: [PATCH] Add shellcheck to pre-commit

Closes #22
---
 .pre-commit-config.yaml    | 7 ++++++-
 privatize_symbols_macos.sh | 2 +-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 5f3fcc1..8b8d510 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -23,4 +23,9 @@ repos:
         description: disallow checking in SHOW_MEMORY=1
         entry: '^#define SHOW_MEMORY 1$'
         language: pygrep
-        types: [c++]
\ No newline at end of file
+        types: [c++]
+  - repo: https://github.com/koalaman/shellcheck-precommit
+    rev: 2491238703a5d3415bb2b7ff11388bf775372f29  # frozen: v0.10.0
+    hooks:
+    -   id: shellcheck
+#       args: ["--severity=warning"]  # Optionally only show errors and warnings
\ No newline at end of file
diff --git a/privatize_symbols_macos.sh b/privatize_symbols_macos.sh
index 4e964eb..2e1b16b 100755
--- a/privatize_symbols_macos.sh
+++ b/privatize_symbols_macos.sh
@@ -2,5 +2,5 @@
 
 # This has the effect of making visibility=hidden symbols private in object files
 for obj in "$@" ; do
-  ld -r $obj -o $obj.tmp && mv $obj.tmp $obj
+  ld -r "$obj" -o "$obj.tmp" && mv "$obj.tmp" "$obj"
 done