weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Avoid function call if no partial key

Browse Source
This commit is contained in:
Andrew Noyes
2024-08-12 16:33:03 -07:00
parent 54e47ebd40
commit 359b0b29ff
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
ConflictSet.cpp
View File

@@ -1125,13 +1125,8 @@ Node *getFirstChildExists(Node *self) {
} }
} }
// Consume any partial key of `self`, and update `self` and void consumePartialKeyFull(Node *&self, std::span<const uint8_t> &key,
// `key` such that `self` is along the search path of `key` InternalVersionT writeVersion, WriteContext *tls) {
void consumePartialKey(Node *&self, std::span<const uint8_t> &key,
InternalVersionT writeVersion, WriteContext *tls) {
if (self->partialKeyLen == 0) {
return;
}
// Handle an existing partial key // Handle an existing partial key
int commonLen = std::min<int>(self->partialKeyLen, key.size()); int commonLen = std::min<int>(self->partialKeyLen, key.size());
int partialKeyIndex = int partialKeyIndex =
@@ -1172,6 +1167,16 @@ void consumePartialKey(Node *&self, std::span<const uint8_t> &key,
key = key.subspan(partialKeyIndex, key.size() - partialKeyIndex); key = key.subspan(partialKeyIndex, key.size() - partialKeyIndex);
} }
// Consume any partial key of `self`, and update `self` and
// `key` such that `self` is along the search path of `key`
inline __attribute__((always_inline)) void
consumePartialKey(Node *&self, std::span<const uint8_t> &key,
InternalVersionT writeVersion, WriteContext *tls) {
if (self->partialKeyLen > 0) {
consumePartialKeyFull(self, key, writeVersion, tls);
}
}
// Caller is responsible for assigning a non-null pointer to the returned // Caller is responsible for assigning a non-null pointer to the returned
// reference if null. Updates child's max version to `newMaxVersion` if child // reference if null. Updates child's max version to `newMaxVersion` if child
// exists but does not have a partial key. // exists but does not have a partial key.