weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Update stale comments
All checks were successful
Tests / Clang total: 2879, passed: 2879
Details
Clang |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / 64 bit versions total: 2879, passed: 2879
Details
Tests / Debug total: 2877, passed: 2877
Details
Tests / SIMD fallback total: 2879, passed: 2879
Details
Tests / Release [gcc] total: 2879, passed: 2879
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / Release [gcc,aarch64] total: 2146, passed: 2146
Details
Tests / Coverage total: 2163, passed: 2163
Details
Code Coverage #### Project Overview No changes detected, that affect the code coverage. * Line Coverage: 99.23% (1803/1817) * Branch Coverage: 68.36% (1426/2086) * Complexity Density: 0.00 * Lines of Code: 1817 #### Quality Gates Summary Output truncated.
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details

Browse Source
This commit is contained in:
Andrew Noyes
2024-09-05 10:06:02 -07:00
parent e2234be10f
commit 56893f9702
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ConflictSet.cpp
View File

@@ -2705,8 +2705,8 @@ bool checkRangeRead(Node *n, std::span<const uint8_t> begin,
auto remaining = begin.subspan(0, lcp); auto remaining = begin.subspan(0, lcp);
Arena arena; Arena arena;
// If the common prefix isn't a prefix of any physical entry in the tree, we
// can go to "downLeftSpine" // Advance down common prefix, but stay on a physical path in the tree
for (;; ++tls->range_read_iterations_accum) { for (;; ++tls->range_read_iterations_accum) {
assert(getSearchPath(arena, n) <=> assert(getSearchPath(arena, n) <=>
begin.subspan(0, lcp - remaining.size()) == begin.subspan(0, lcp - remaining.size()) ==
@@ -2750,7 +2750,7 @@ bool checkRangeRead(Node *n, std::span<const uint8_t> begin,
return checkRangeRightSide(n, end, lcp, readVersion, tls); return checkRangeRightSide(n, end, lcp, readVersion, tls);
} }
// This makes it safe to check maxVersion within CheckRangeLeftSide. If this // This makes it safe to check maxVersion within checkRangeLeftSide. If this
// were false, then we would have returned above since lcp == begin.size(). // were false, then we would have returned above since lcp == begin.size().
assert(!(n->parent == nullptr && begin.size() == 0)); assert(!(n->parent == nullptr && begin.size() == 0));