weaselab/conflict-set
1
Fork 1
Code Issues 6 Pull Requests Actions 1 Packages Releases 13 Activity

Remove redundant version update

Browse Source 
A write can never lower the logical max version of a key range.
There's no read that didn't pass before that should pass after a write.
This commit is contained in:
andrew committed 2026-10-09 16:19:20 -04:00
1 parent 2f9f49c692
commit 647ba5beb1
1 file changed
-1
Download Patch File Download Diff File Expand all files Collapse all files
ConflictSet.cpp
-1
View File
@@ -2022,7 +2022,6 @@ Node *erase(Node *self, WriteContext *writeContext, bool logical) {
parent48->index[parentIndex] = toRemoveChildrenIndex; parent48->index[parentIndex] = toRemoveChildrenIndex;
parent48->reverseIndex[toRemoveChildrenIndex] = parentIndex; parent48->reverseIndex[toRemoveChildrenIndex] = parentIndex;
} }
parent48->childMaxVersion[lastChildrenIndex] = writeContext->zero;
VALGRIND_MAKE_MEM_UNDEFINED(parent48->children + lastChildrenIndex, VALGRIND_MAKE_MEM_UNDEFINED(parent48->children + lastChildrenIndex,
sizeof(parent48->children[0])); sizeof(parent48->children[0]));
VALGRIND_MAKE_MEM_UNDEFINED(parent48->reverseIndex + lastChildrenIndex, VALGRIND_MAKE_MEM_UNDEFINED(parent48->reverseIndex + lastChildrenIndex,