weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Avoid memmove when inserting into Node3

Browse Source
This commit is contained in:
Andrew Noyes
2024-08-02 13:33:18 -07:00
parent 620a0afd2a
commit 72168ef6a3
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
ConflictSet.cpp
View File

@@ -1122,24 +1122,19 @@ Node *&getOrCreateChild(Node *&self, uint8_t index, WriteContext *tls) {
insert3: insert3:
auto *self3 = static_cast<Node3 *>(self); auto *self3 = static_cast<Node3 *>(self);
++self->numChildren; int i = self->numChildren - 1;
int i = 0; for (; i >= 0; --i) {
for (; i < self->numChildren - 1; ++i) { if (int(self3->index[i]) < int(index)) {
if (int(self3->index[i]) > int(index)) {
memmove(self3->index + i + 1, self3->index + i,
self->numChildren - (i + 1));
memmove(self3->children + i + 1, self3->children + i,
(self->numChildren - (i + 1)) *
sizeof(self3->children[0])); // NOLINT
memmove(self3->childMaxVersion + i + 1, self3->childMaxVersion + i,
(self->numChildren - (i + 1)) *
sizeof(self3->childMaxVersion[0]));
break; break;
} }
self3->index[i + 1] = self3->index[i];
self3->children[i + 1] = self3->children[i];
self3->childMaxVersion[i + 1] = self3->childMaxVersion[i];
} }
self3->index[i] = index; self3->index[i + 1] = index;
auto &result = self3->children[i]; auto &result = self3->children[i + 1];
result = nullptr; result = nullptr;
++self->numChildren;
return result; return result;
} }
case Type_Node16: { case Type_Node16: {