weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Save more redundant nullptr checks

Browse Source
This commit is contained in:
Andrew Noyes
2024-03-19 14:34:59 -07:00
parent cb4c2b7e1e
commit 727b7e642a
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ConflictSet.cpp
View File

@@ -1698,6 +1698,9 @@ bool checkRangeStartsWith(Node *n, std::span<const uint8_t> key, int begin,
goto downLeftSpine; goto downLeftSpine;
} else { } else {
n = nextSibling(n); n = nextSibling(n);
if (n == nullptr) {
return true;
}
goto downLeftSpine; goto downLeftSpine;
} }
} }
@@ -1715,6 +1718,9 @@ bool checkRangeStartsWith(Node *n, std::span<const uint8_t> key, int begin,
goto downLeftSpine; goto downLeftSpine;
} else { } else {
n = nextSibling(n); n = nextSibling(n);
if (n == nullptr) {
return true;
}
goto downLeftSpine; goto downLeftSpine;
} }
} }
@@ -1732,9 +1738,6 @@ bool checkRangeStartsWith(Node *n, std::span<const uint8_t> key, int begin,
__builtin_unreachable(); // GCOVR_EXCL_LINE __builtin_unreachable(); // GCOVR_EXCL_LINE
downLeftSpine: downLeftSpine:
if (n == nullptr) {
return true;
}
for (;;) { for (;;) {
if (n->entryPresent) { if (n->entryPresent) {
return n->entry.rangeVersion <= readVersion; return n->entry.rangeVersion <= readVersion;