weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Add TODO
Some checks failed
Tests / Release [gcc] total: 361, failed: 2, passed: 359
Details
Tests / Coverage total: 359, passed: 359
Details
weaselab/conflict-set/pipeline/head There was a failure building this commit
Details

Browse Source
This commit is contained in:
Andrew Noyes
2024-02-08 10:16:31 -08:00
parent d388f6488d
commit b018ccc3ae
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ConflictSet.cpp
View File

@@ -604,9 +604,11 @@ Iterator firstGeq(Node *n, const std::span<const uint8_t> key) {
return {stepwise.n, stepwise.cmp}; return {stepwise.n, stepwise.cmp};
} }
// TODO rewrite in terms of FirstGeqStepwise?
//
// Logically this is the same as performing firstGeq and then checking against // Logically this is the same as performing firstGeq and then checking against
// point or range version according to cmp, but this version short circuits as // point or range version according to cmp, but this version short circuits as
// soon as it can prove that there's no conflict // soon as it can prove that there's no conflict.
bool checkPointRead(Node *n, const std::span<const uint8_t> key, bool checkPointRead(Node *n, const std::span<const uint8_t> key,
int64_t readVersion) { int64_t readVersion) {
auto remaining = key; auto remaining = key;