weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Document that erase may invalidate search path

Browse Source 
It doesn't yet, but it will when we downsize nodes.
This commit is contained in:
Andrew Noyes
2024-03-11 22:47:48 -07:00
parent 5e4eab55fb
commit b721bc80a9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ConflictSet.cpp
View File

@@ -727,7 +727,8 @@ Node *nextLogical(Node *node) {
return node; return node;
} }
// Precondition: self is not the root // Precondition: self is not the root. May invalidate nodes along the search
// path to self.
Node *erase(Node *self, NodeAllocators *allocators, ConflictSet::Impl *impl) { Node *erase(Node *self, NodeAllocators *allocators, ConflictSet::Impl *impl) {
assert(self->parent != nullptr); assert(self->parent != nullptr);
@@ -1577,7 +1578,7 @@ bool checkRangeRead(Node *n, std::span<const uint8_t> begin,
// Returns a pointer to the newly inserted node. Caller must set // Returns a pointer to the newly inserted node. Caller must set
// `entryPresent`, `entry` fields and `maxVersion` on the result. The search // `entryPresent`, `entry` fields and `maxVersion` on the result. The search
// path of the result's parent will have `maxVersion` at least `writeVersion` as // path of the result's parent will have `maxVersion` at least `writeVersion` as
// a postcondition. Nodes along the search path may be invalidated. // a postcondition. Nodes along the search path to `key` may be invalidated.
template <bool kBegin> template <bool kBegin>
[[nodiscard]] Node *insert(Node **self, std::span<const uint8_t> key, [[nodiscard]] Node *insert(Node **self, std::span<const uint8_t> key,
int64_t writeVersion, NodeAllocators *allocators, int64_t writeVersion, NodeAllocators *allocators,