weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Avoid redundant null check in some cases
All checks were successful
Tests / Clang total: 825, passed: 825
Details
Clang |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / Release [gcc] total: 825, passed: 825
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / Release [gcc,aarch64] total: 824, passed: 824
Details
Tests / Coverage total: 823, passed: 823
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details

Browse Source
This commit is contained in:
Andrew Noyes
2024-03-19 14:29:13 -07:00
parent ef9b789745
commit cb4c2b7e1e
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ConflictSet.cpp
View File

@@ -1540,6 +1540,9 @@ bool checkPointRead(Node *n, const std::span<const uint8_t> key,
goto downLeftSpine; goto downLeftSpine;
} else { } else {
n = nextSibling(n); n = nextSibling(n);
if (n == nullptr) {
return true;
}
goto downLeftSpine; goto downLeftSpine;
} }
} }
@@ -1556,6 +1559,9 @@ bool checkPointRead(Node *n, const std::span<const uint8_t> key,
goto downLeftSpine; goto downLeftSpine;
} else { } else {
n = nextSibling(n); n = nextSibling(n);
if (n == nullptr) {
return true;
}
goto downLeftSpine; goto downLeftSpine;
} }
} }
@@ -1570,9 +1576,6 @@ bool checkPointRead(Node *n, const std::span<const uint8_t> key,
} }
} }
downLeftSpine: downLeftSpine:
if (n == nullptr) {
return true;
}
for (;;) { for (;;) {
if (n->entryPresent) { if (n->entryPresent) {
return n->entry.rangeVersion <= readVersion; return n->entry.rangeVersion <= readVersion;