Clean up some vestiges of fixed-size partial keys

CMakeLists.txt

@@ -92,12 +92,7 @@ if(NOT APPLE AND CMAKE_OBJCOPY)
       $<TARGET_FILE:${PROJECT_NAME}_static>)
 endif()
 
-set(TEST_FLAGS -Wall -Wextra -Wunreachable-code -UNDEBUG)
+set(TEST_FLAGS -Wall -Wextra -Wunreachable-code -Wpedantic -UNDEBUG)
-
-if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
-  list(APPEND TEST_FLAGS -Wpedantic -Wno-gnu-anonymous-struct
-       -Wno-nested-anon-types)
-endif()
 
 include(CTest)
 

ConflictSet.cpp

@@ -181,6 +181,9 @@ struct Node {
 
   Type type;
 #ifndef NDEBUG
+  // Leaving this uninitialized is intentional and necessary to expect asserts
+  // to pass. Basically it needs to be preserved when going to the free list and
+  // back.
   int32_t partialKeyCapacity;
 #endif
 
@@ -325,6 +328,8 @@ uint8_t *Node::partialKey() {
   case Type::Node256:
     return ((Node256 *)this)->partialKey();
   }
+  __builtin_unreachable();
+  ; // GCOVR_EXCL_LINE
 }
 
 struct NodeAllocators {