weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Fix range_read_total counter
All checks were successful
Tests / Clang total: 1533, passed: 1533
Details
Clang |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / Debug total: 1531, passed: 1531
Details
Tests / SIMD fallback total: 1533, passed: 1533
Details
Tests / Release [gcc] total: 1533, passed: 1533
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Details
Tests / Release [gcc,aarch64] total: 1144, passed: 1144
Details
Tests / Coverage total: 1151, passed: 1151
Details
Code Coverage #### Project Overview No changes detected, that affect the code coverage. * Line Coverage: 98.72% (1693/1715) * Branch Coverage: 64.63% (1502/2324) * Complexity Density: 0.00 * Lines of Code: 1715 #### Quality Gates Summary Output truncated.
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details

Browse Source 
It was overcounting
This commit is contained in:
Andrew Noyes
2024-07-15 14:09:31 -07:00
parent ffd1dfe74d
commit e7806a36d1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ConflictSet.cpp
View File

@@ -2649,7 +2649,6 @@ template <bool kAVX512>
bool checkRangeReadImpl(Node *n, std::span<const uint8_t> begin, bool checkRangeReadImpl(Node *n, std::span<const uint8_t> begin,
std::span<const uint8_t> end, std::span<const uint8_t> end,
InternalVersionT readVersion, ConflictSet::Impl *impl) { InternalVersionT readVersion, ConflictSet::Impl *impl) {
++range_read_accum;
int lcp = longestCommonPrefix(begin.data(), end.data(), int lcp = longestCommonPrefix(begin.data(), end.data(),
std::min(begin.size(), end.size())); std::min(begin.size(), end.size()));
if (lcp == int(begin.size()) && end.size() == begin.size() + 1 && if (lcp == int(begin.size()) && end.size() == begin.size() + 1 &&
@@ -2661,6 +2660,8 @@ bool checkRangeReadImpl(Node *n, std::span<const uint8_t> begin,
return checkPrefixRead(n, begin, readVersion, impl); return checkPrefixRead(n, begin, readVersion, impl);
} }
++range_read_accum;
SearchStepWise search{n, begin.subspan(0, lcp)}; SearchStepWise search{n, begin.subspan(0, lcp)};
Arena arena; Arena arena;
for (;;) { for (;;) {