weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity
418 Commits 7 Branches 13 Tags
ddeb059968e465324d5339df9e2a9c560d90925e
Commit Graph

298 Commits

Author SHA1 Message Date
Andrew Noyes
172dd40648 Check for full words on boundaries 2024-02-26 10:36:45 -08:00
Andrew Noyes
c97c7eee8e Speed up sparse queries
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/39//gcc">weaselab » conflict-set » main #39</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-25 23:08:01 -08:00
Andrew Noyes
9fcfc44dc3 Add forEachInRange 2024-02-25 21:04:39 -08:00
Andrew Noyes
0d3475e229 Use uint64_t array and fewer branches in BitSet
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/38//gcc">weaselab » conflict-set » main #38</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-24 18:20:00 -08:00
Andrew Noyes
adaa652d0d Remove Node::maxVersion 2024-02-23 17:27:19 -08:00
Andrew Noyes
921005edb3 Add childMaxVersion 2024-02-23 17:02:46 -08:00
Andrew Noyes
df8d092a84 Avoid some unnecessary work
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/36//gcc">weaselab » conflict-set » main #36</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-23 14:49:42 -08:00
Andrew Noyes
438a2e2abc Make sure setOldestVersion has work to do in bench 2024-02-23 14:41:05 -08:00
Andrew Noyes
305c218888 Skip checking for partial key match if partial key len == 0 
This saves instructions according to cachegrind
 2024-02-23 14:27:20 -08:00
Andrew Noyes
db60782c48 Use **self directly in insert 2024-02-23 14:09:04 -08:00
Andrew Noyes
4f32ecc26e Make "begin" a template parameter to insert 
cachegrind says this saves instructions
 2024-02-23 14:00:55 -08:00
Andrew Noyes
f84aa88202 Copy old node to new more efficiently 
Presumably it's generating good code for the memcpy with a static size,
and hopefully also eliminating redundant stores
 2024-02-23 13:31:05 -08:00
Andrew Noyes
921da1cb3f Remove redundant code 2024-02-23 13:13:48 -08:00
Andrew Noyes
14de4ee297 Specialize setChildrenParents for each node type 
cachegrind says this increases the instruction count somehow. I'm not
sure what's going on there.
 2024-02-23 13:09:42 -08:00
Andrew Noyes
7136b5a450 Save more instructions in getOrCreateChild 
Take advantage of the property that Node4 is a prefix of Node16
 2024-02-23 12:39:24 -08:00
Andrew Noyes
116c79d3de Optimize getOrCreateChild 
Add fast path for if it exists

Avoid some unnecessary branches

Try to simplify some
 2024-02-23 12:34:28 -08:00
Andrew Noyes
aaf0283f66 Prefer getChild to getChildGeq in happy path 
Saves instructions according to cachegrind
 2024-02-23 12:12:01 -08:00
Andrew Noyes
259f47664a Save some instructions in getOrCreateChild
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/35//gcc">weaselab » conflict-set » main #35</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-22 22:46:08 -08:00
Andrew Noyes
9a47f2d03a Fixed missed usages of longestCommonPrefixPartialKey
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/34//gcc">weaselab » conflict-set » main #34</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-22 16:24:26 -08:00
Andrew Noyes
b5d5085fd5 Add precondition back to firstNeqStride 2024-02-22 16:16:42 -08:00
Andrew Noyes
40dca168ba Add precondition to longestCommonPrefixPartialKey
All checks were successful
Tests / Release [gcc] total: 471, passed: 471
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/33//gcc">weaselab » conflict-set » main #33</a>
Details
Tests / Coverage total: 469, passed: 469
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-22 16:07:20 -08:00
Andrew Noyes
7a8233ac61 More unnesting 2024-02-22 15:50:54 -08:00
Andrew Noyes
3c93b9a3ce Unnest some in checkPointRead 2024-02-22 15:43:13 -08:00
Andrew Noyes
c16feda9f8 Use longestCommonPrefixPartialKey in SearchStepWise 2024-02-22 15:41:39 -08:00
Andrew Noyes
4c3e7aef30 Save a few instructions in SearchStepWise 2024-02-22 15:30:24 -08:00
Andrew Noyes
7f5598af2b Save a few instructions in addWriteRange 2024-02-22 15:25:50 -08:00
Andrew Noyes
8016d44c04 Use simple loop for longestCommonPrefixPartialKey 
The benchmark has this as faster
 2024-02-22 14:49:04 -08:00
Andrew Noyes
505c060a28 Use longestCommonPrefixPartialKey in insert 2024-02-22 14:46:52 -08:00
Andrew Noyes
608b4fb6c7 Remove some branches 2024-02-22 14:29:24 -08:00
Andrew Noyes
0fbc8b0190 Use longestCommonPrefix on partial keys 2024-02-22 13:57:00 -08:00
Andrew Noyes
3a5db2d2ac Share some Node4/16 and Node48/256 implementations 
This cuts down on the number of instructions (confirmed with
cachegrind). Also avoid initializing some memory unnecessarily.
 2024-02-22 12:31:10 -08:00
Andrew Noyes
09782ba833 Fix O(k^2) behavior when begin is a prefix of end
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/32//gcc">weaselab » conflict-set » main #32</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-21 20:11:37 -08:00
Andrew Noyes
3750aa7b5b Vendor valgrind headers
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/31//gcc">weaselab » conflict-set » main #31</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details 
This is encouraged according to https://valgrind.org/docs/manual/manual-core-adv.html#manual-core-adv.clientreq
 2024-02-21 16:15:40 -08:00
Andrew Noyes
28e61340f4 Add valgrind annotations
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/30//gcc">weaselab » conflict-set » main #30</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details 
This appears to affect the binary (how else could it possibly work??),
but the microbenchmarks don't show a difference
 2024-02-21 15:58:01 -08:00
Andrew Noyes
07839b4687 Fix class-memaccess warning
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|4|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/29//gcc">weaselab » conflict-set » main #29</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details 
The lifetime of T ended, so it's appropriate to treat it as a void*
 2024-02-21 15:27:46 -08:00
Andrew Noyes
af269ff208 Use a free list
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |4|4|0|0|:-1: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/27//gcc">weaselab » conflict-set » main #27</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details 
malloc and free were showing up in profiles of fdbserver
 2024-02-21 13:51:02 -08:00
Andrew Noyes
7e6652003b Remove vestigial arena 2024-02-21 12:06:57 -08:00
Andrew Noyes
48d96ac79a Only pass key to addPointWrite
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/26//gcc">weaselab » conflict-set » main #26</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-20 23:16:03 -08:00
Andrew Noyes
a341b36f63 Detect singleton key ranges
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/25//gcc">weaselab » conflict-set » main #25</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-20 23:09:03 -08:00
Andrew Noyes
4cbbeab55d Remove dead code
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/23//gcc">weaselab » conflict-set » main #23</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-20 15:30:07 -08:00
Andrew Noyes
06f92722f0 Add license
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/22//gcc">weaselab » conflict-set » main #22</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-20 13:22:22 -08:00
Andrew Noyes
ae5277bf78 Interleave checking left and right side
All checks were successful
Tests / Release [gcc] total: 583, passed: 583
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/20//gcc">weaselab » conflict-set » main #20</a>
Details
Tests / Coverage total: 581, passed: 581
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-20 11:28:58 -08:00
Andrew Noyes
c4e18d71a2 CheckRangeRightSide struct 2024-02-20 11:12:10 -08:00
Andrew Noyes
33390af817 CheckRangeLeftSide struct 2024-02-20 11:04:12 -08:00
Andrew Noyes
01a29b69b1 Explain assert 2024-02-19 16:25:15 -08:00
Andrew Noyes
cb2f66b4b7 Remove a check from setOldestVersion 2024-02-19 16:20:04 -08:00
Andrew Noyes
c9baa80212 Implement setOldestVersion 2024-02-19 15:58:59 -08:00
Andrew Noyes
79390b806c Don't repeat common prefix search in addWriteRange
All checks were successful
Tests / Release [gcc] total: 423, passed: 423
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/18//gcc">weaselab » conflict-set » main #18</a>
Details
Tests / Coverage total: 421, passed: 421
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-18 10:43:41 -08:00
Andrew Noyes
cb31f4c25b Fix bugs
All checks were successful
Tests / Release [gcc] total: 423, passed: 423
Details
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap: Reference build: <a href="https://jenkins.weaselab.dev/job/weaselab/job/conflict-set/job/main/17//gcc">weaselab » conflict-set » main #17</a>
Details
Tests / Coverage total: 421, passed: 421
Details
weaselab/conflict-set/pipeline/head This commit looks good
Details
2024-02-17 22:09:00 -08:00
Andrew Noyes
0799aea3e8 Move newly test-only code 2024-02-16 18:35:28 -08:00