Run valgrind in arm64 release in CI

Add .note.gnu.property section for CET/CFI to simd_x86_64.S
The assembly file was missing the GNU property note that records control-flow integrity (CET) support, causing hardening-check to report 'Control flow integrity: no, not found!'. Add the note matching what clang emits with -fcf-protection.
2026-08-03 02:36:45 +00:00 · 2026-08-02 22:31:56 -04:00
2 changed files with 12 additions and 6 deletions
@@ -185,12 +185,7 @@ jobs:
      - name: Test
        run: |
          cd build
-          # On arm64, valgrind needs the MAKE_MEM_DEFINED client requests for
-          # https://git.weaselab.dev/weaselab/conflict-set/issues/39, but this
-          # build has -DNVALGRIND, which compiles them out. Skip valgrind
-          # tests here; they run annotated in the test job.
-          ctest --no-compress-output --test-output-size-passed 100000 --test-output-size-failed 100000 ${{ matrix.arch == 'arm64' && '-E valgrind' || '' }} -T Test -j "$(nproc)" --timeout 90 > /dev/null
-
+          ctest --no-compress-output --test-output-size-passed 100000 --test-output-size-failed 100000 -T Test -j "$(nproc)" --timeout 90 > /dev/null
      - name: Package
        run: |
          cd build
@@ -71,4 +71,15 @@ mask_in_range_16:
    ret
    .size mask_in_range_16, .-mask_in_range_16

+    .section .note.gnu.property,"a",@note
+    .p2align 3, 0x0
+    .long 4
+    .long 16
+    .long 5
+    .asciz "GNU"
+    .long 0xc0000002
+    .long 4
+    .long 0x3
+    .p2align 3, 0x0
+
    .section .note.GNU-stack,"",@progbits
Author	SHA1	Message	Date
andrew	79113ecb88	Run valgrind in arm64 release in CI CI / release (arm64, , ubuntu-latest-arm64) (push) Successful in 3m22s Details CI / release (arm64, , ubuntu-latest-arm64) (pull_request) Successful in 3m21s Details CI / pre-commit (push) Successful in 2m37s Details CI / test (-DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, debug) (push) Successful in 3m50s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (push) Successful in 3m22s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (push) Successful in 3m12s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (push) Successful in 3m17s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (push) Successful in 5m32s Details CI / coverage (push) Successful in 3m50s Details CI / pre-commit (pull_request) Successful in 2m2s Details CI / test (-DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, debug) (pull_request) Successful in 3m51s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m18s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m14s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m19s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (pull_request) Successful in 5m39s Details CI / coverage (pull_request) Successful in 3m49s Details	2026-08-03 02:36:45 +00:00
andrew	5c16b8ee90	Add .note.gnu.property section for CET/CFI to simd_x86_64.S CI / release (arm64, , ubuntu-latest-arm64) (push) Successful in 2m21s Details CI / pre-commit (push) Successful in 2m1s Details CI / test (-DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, debug) (push) Successful in 3m48s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (push) Successful in 3m18s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (push) Successful in 3m15s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (push) Successful in 3m17s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (push) Successful in 5m33s Details CI / coverage (push) Successful in 3m47s Details The assembly file was missing the GNU property note that records control-flow integrity (CET) support, causing hardening-check to report 'Control flow integrity: no, not found!'. Add the note matching what clang emits with -fcf-protection.	2026-08-02 22:31:56 -04:00