Enable relro for shared lib

Unsuppress -Wmaybe-uninitialized
I don't see the warning anymore locally
2024-03-29 21:51:02 -07:00 · 2024-03-29 18:57:43 -07:00
1 changed files with 5 additions and 4 deletions
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -33,8 +33,7 @@ option(USE_SIMD_FALLBACK
 include_directories(SYSTEM ${CMAKE_SOURCE_DIR}/third_party/valgrind)
 if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-  add_compile_options(-Wno-maybe-uninitialized
+  add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Wno-invalid-offsetof>)
                      $<$<COMPILE_LANGUAGE:CXX>:-Wno-invalid-offsetof>)
 endif()
 if(APPLE)
@@ -79,8 +78,10 @@ if(NOT CMAKE_BUILD_TYPE STREQUAL Debug)
 endif()
 if(NOT APPLE)
-  target_link_options(${PROJECT_NAME} PRIVATE
+  target_link_options(
-                      LINKER:--version-script=${CMAKE_SOURCE_DIR}/linker.map)
+    ${PROJECT_NAME} PRIVATE
    LINKER:--version-script=${CMAKE_SOURCE_DIR}/linker.map
    LINKER:-z,relro,-z,now,-z,noexecstack)
 endif()
 add_library(${PROJECT_NAME}-static STATIC
Author	SHA1	Message	Date
Andrew Noyes	348ebf016a	Enable relro for shared lib All checks were successful Tests / Clang total: 1096, passed: 1096 Details Clang \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / SIMD fallback total: 1096, passed: 1096 Details Tests / Release [gcc] total: 1096, passed: 1096 Details GNU C Compiler (gcc) \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / Release [gcc,aarch64] total: 824, passed: 824 Details Tests / Coverage total: 823, passed: 823 Details weaselab/conflict-set/pipeline/head This commit looks good Details	2024-03-29 21:51:02 -07:00
Andrew Noyes	377259ffa0	Unsuppress -Wmaybe-uninitialized I don't see the warning anymore locally	2024-03-29 18:57:43 -07:00