Merge pull request 'Replace SIMD assembly with initialized Node16::index + valgrind client request' (#77 ) from client-request-instead-of-asm into main

Reviewed-on: #77
Poison Node48 reverseIndex slot on erase
2026-08-04 00:07:19 +00:00 · 2026-08-03 17:38:21 -04:00
1 changed files with 2 additions and 0 deletions
@@ -2025,6 +2025,8 @@ Node *erase(Node *self, WriteContext *writeContext, bool logical) {
    parent48->childMaxVersion[lastChildrenIndex] = writeContext->zero;
    VALGRIND_MAKE_MEM_UNDEFINED(parent48->children + lastChildrenIndex,
                                sizeof(parent48->children[0]));
    VALGRIND_MAKE_MEM_UNDEFINED(parent48->reverseIndex + lastChildrenIndex,
                                sizeof(parent48->reverseIndex[0]));
    if (needsDownsize(parent48)) {
      downsize(parent48, writeContext);
Author	SHA1	Message	Date
andrew	cdbad1c013	Merge pull request 'Replace SIMD assembly with initialized Node16::index + valgrind client request' (#77 ) from client-request-instead-of-asm into main CI / pre-commit (push) Successful in 2m1s Details CI / test (arm64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 22, https://minio.weaselab.dev/public/aarch64/msan-toolchain-22.1.8.tar.zst, debug-arm64, ubuntu-latest-arm64) (push) Successful in 3m46s Details CI / test (amd64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 21, https://minio.weaselab.dev/public/x86_64/msan-toolchain-21.1.8.tar.zst, debug, ubuntu-latest-amd64) (push) Successful in 3m50s Details CI / release (arm64, , ubuntu-latest-arm64) (push) Successful in 3m18s Details CI / test (amd64, -DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 21, , 64-bit-versions, ubuntu-latest-amd64) (push) Successful in 3m19s Details CI / test (amd64, -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, 21, , gcc, ubuntu-latest-amd64) (push) Successful in 3m18s Details CI / test (amd64, -DUSE_SIMD_FALLBACK=ON, 21, , simd-fallback, ubuntu-latest-amd64) (push) Successful in 3m25s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (push) Successful in 5m50s Details CI / coverage (push) Successful in 4m0s Details Reviewed-on: #77	2026-08-04 00:07:19 +00:00
andrew	6d9810fe7f	Poison Node48 reverseIndex slot on erase CI / test (arm64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 22, https://minio.weaselab.dev/public/aarch64/msan-toolchain-22.1.8.tar.zst, debug-arm64, ubuntu-latest-arm64) (push) Successful in 3m46s Details CI / release (arm64, , ubuntu-latest-arm64) (push) Successful in 3m21s Details CI / test (arm64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 22, https://minio.weaselab.dev/public/aarch64/msan-toolchain-22.1.8.tar.zst, debug-arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m50s Details CI / release (arm64, , ubuntu-latest-arm64) (pull_request) Successful in 3m24s Details CI / pre-commit (push) Successful in 2m5s Details CI / test (amd64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 21, https://minio.weaselab.dev/public/x86_64/msan-toolchain-21.1.8.tar.zst, debug, ubuntu-latest-amd64) (push) Successful in 3m56s Details CI / test (amd64, -DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 21, , 64-bit-versions, ubuntu-latest-amd64) (push) Successful in 3m23s Details CI / test (amd64, -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, 21, , gcc, ubuntu-latest-amd64) (push) Successful in 3m31s Details CI / test (amd64, -DUSE_SIMD_FALLBACK=ON, 21, , simd-fallback, ubuntu-latest-amd64) (push) Successful in 3m24s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (push) Successful in 5m46s Details CI / coverage (push) Successful in 3m55s Details CI / pre-commit (pull_request) Successful in 2m8s Details CI / test (amd64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 21, https://minio.weaselab.dev/public/x86_64/msan-toolchain-21.1.8.tar.zst, debug, ubuntu-latest-amd64) (pull_request) Successful in 3m53s Details CI / test (amd64, -DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 21, , 64-bit-versions, ubuntu-latest-amd64) (pull_request) Successful in 3m21s Details CI / test (amd64, -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, 21, , gcc, ubuntu-latest-amd64) (pull_request) Successful in 3m20s Details CI / test (amd64, -DUSE_SIMD_FALLBACK=ON, 21, , simd-fallback, ubuntu-latest-amd64) (pull_request) Successful in 3m20s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (pull_request) Successful in 5m46s Details CI / coverage (pull_request) Successful in 4m5s Details When a Node48 loses a child, the vacated reverseIndex slot would otherwise remain defined, letting valgrind miss reads that rely on the stale value. Mark it undefined, mirroring the existing poisoning of the vacated children slot.	2026-08-03 17:38:21 -04:00