Merge pull request 'Disallow copying ConflictSet in C++98/C++03' (#51 ) from weaselbot/conflict-set:weaselbot/issue-48 into main

Reviewed-on: #51
We already know __cplusplus is defined
2026-06-22 23:44:59 +00:00 · 2026-06-22 14:18:33 -04:00 · 2026-06-22 13:43:04 -04:00
1 changed files with 7 additions and 0 deletions
@@ -132,6 +132,13 @@ struct __attribute__((__visibility__("default"))) ConflictSet {

 private:
  Impl *impl;
+#if __cplusplus <= 199711L
+  /* Declared private and left undefined to prevent copying in C++98/C++03.
+     The compiler would otherwise implicitly generate public copy operations,
+     which share the opaque Impl* and cause a double-free. */
+  ConflictSet(const ConflictSet &);
+  ConflictSet &operator=(const ConflictSet &);
+#endif
 };
 } /* namespace weaselab */
Author	SHA1	Message	Date
andrew	b9b2d69dd5	Merge pull request 'Disallow copying ConflictSet in C++98/C++03' (#51 ) from weaselbot/conflict-set:weaselbot/issue-48 into main CI / pre-commit (push) Successful in 2m8s Details CI / release (arm64, ubuntu-latest-arm64) (push) Successful in 3m34s Details CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (push) Successful in 3m38s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (push) Successful in 3m28s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (push) Successful in 3m37s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (push) Successful in 3m29s Details CI / release (amd64, ubuntu-latest-amd64) (push) Successful in 4m57s Details CI / coverage (push) Successful in 3m42s Details Reviewed-on: #51	2026-06-22 23:44:59 +00:00
andrew	ccd637deab	We already know __cplusplus is defined CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m21s Details CI / pre-commit (pull_request) Successful in 2m6s Details CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m35s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m27s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m39s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m34s Details CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 4m53s Details CI / coverage (pull_request) Successful in 3m36s Details	2026-06-22 14:18:33 -04:00
weaselbot	7eaac2a184	Make ConflictSet non-copyable in C++98/C++03 CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m20s Details CI / pre-commit (pull_request) Successful in 2m5s Details CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m37s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m27s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m37s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m27s Details CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 4m52s Details CI / coverage (pull_request) Successful in 3m37s Details `ConflictSet(const ConflictSet&)` and `operator=(const ConflictSet&)` were only deleted for C++11 and later. In C++98/C++03 the compiler implicitly generated public copy operations, so copying a ConflictSet shared the opaque `Impl*` and caused a double-free on destruction. Declare both operations private and leave them undefined when `__cplusplus <= 199711L`, matching the standard pre-C++11 idiom for move-only types. Guard the declarations with `defined(__cplusplus)` so they are not exposed to C90 compilation units. Closes #48	2026-06-22 13:43:04 -04:00