Add memcmp to aarch64 imports

Run gc less frequently
But still run it to account for the version potentially increasing
2024-10-31 15:36:19 -07:00 · 2024-10-31 15:35:00 -07:00
2 changed files with 4 additions and 5 deletions
--- a/ConflictSet.cpp
+++ b/ConflictSet.cpp
@@ -5128,9 +5128,6 @@ struct __attribute__((visibility("hidden"))) ConflictSet::Impl {
    assert(writeContext.accum.entries_erased == 0);
    assert(writeContext.accum.entries_inserted == 0);

-    // Queue up some gc work just for (potentially) increasing the version
-    ++keyUpdates;
-
    if (oldestExtantVersion < writeVersion - kMaxCorrectVersionWindow)
        [[unlikely]] {
      if (writeVersion > newestVersionFullPrecision + kNominalVersionWindow) {
@@ -5187,10 +5184,11 @@ struct __attribute__((visibility("hidden"))) ConflictSet::Impl {

    writeContext.releaseDeferred();

-    // Run gc at least 200% the rate we're inserting entries
+    // Run gc at least 200% the rate we're inserting entries, and at least run
+    // some gc just for potentially increasing the version.
    keyUpdates += std::max<int64_t>(writeContext.accum.entries_inserted -
                                        writeContext.accum.entries_erased,
-                                    0) *
+                                    1) *
                  2;

    point_writes_total.add(writeContext.accum.point_writes);
--- a/aarch64-symbol-imports.txt
+++ b/aarch64-symbol-imports.txt
@@ -5,6 +5,7 @@ __stack_chk_guard@GLIBC_2.17
 abort@GLIBC_2.17
 free@GLIBC_2.17
 malloc@GLIBC_2.17
+memcmp@GLIBC_2.17
 memcpy@GLIBC_2.17
 memmove@GLIBC_2.17
 memset@GLIBC_2.17
Author	SHA1	Message	Date
Andrew Noyes	c7e2358746	Add memcmp to aarch64 imports Some checks failed Tests / 64 bit versions total: 6074, passed: 6074 Details Tests / Debug total: 6072, passed: 6072 Details Tests / SIMD fallback total: 6074, passed: 6074 Details Tests / Release [clang] total: 6074, passed: 6074 Details Clang \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / Release [gcc] total: 6074, passed: 6074 Details GNU C Compiler (gcc) \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / Release [clang,aarch64] total: 4022, passed: 4022 Details Tests / Coverage total: 4063, passed: 4063 Details Code Coverage #### Project Overview No changes detected, that affect the code coverage. * Line Coverage: 97.12% (3104/3196) * Branch Coverage: 46.76% (13216/28261) * Complexity Density: 0.00 * Lines of Code: 3196 #### Quality Gates Summary Output truncated. Details weaselab/conflict-set/pipeline/head There was a failure building this commit Details	2024-10-31 15:36:19 -07:00
Andrew Noyes	ec1c1cf43f	Run gc less frequently But still run it to account for the version potentially increasing	2024-10-31 15:35:00 -07:00