Use PRE_LINK

According to https://cmake.org/cmake/help/latest/command/add_custom_command.html this more accurately matches the intent
Don't update mtime in privatize_symbols_macos.sh
2024-04-04 17:03:57 -07:00 · 2024-04-04 17:02:51 -07:00
2 changed files with 4 additions and 2 deletions
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -128,7 +128,7 @@ endif()
 if(APPLE)
  add_custom_command(
    TARGET ${PROJECT_NAME}-static
-    PRE_BUILD
+    PRE_LINK
    COMMAND ${CMAKE_SOURCE_DIR}/privatize_symbols_macos.sh
            $<TARGET_OBJECTS:${PROJECT_NAME}-object>)
 else()
--- a/privatize_symbols_macos.sh
+++ b/privatize_symbols_macos.sh
@@ -2,5 +2,7 @@

 # This has the effect of making visibility=hidden symbols private in object files
 for obj in "$@" ; do
-  ld -r "$obj" -o "$obj.tmp" && mv "$obj.tmp" "$obj"
+  ld -r "$obj" -o "$obj.tmp"
+  touch -r "$obj" "$obj.tmp"
+  mv "$obj.tmp" "$obj"
 done
Author	SHA1	Message	Date
Andrew Noyes	1c900c5a8c	Use PRE_LINK All checks were successful Tests / Clang total: 1096, passed: 1096 Details Clang \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / SIMD fallback total: 1096, passed: 1096 Details Tests / Release [gcc] total: 1096, passed: 1096 Details GNU C Compiler (gcc) \|Total\|New\|Outstanding\|Fixed\|Trend \|:-:\|:-:\|:-:\|:-:\|:-: \|0\|0\|0\|0\|:clap: Details Tests / Release [gcc,aarch64] total: 824, passed: 824 Details Tests / Coverage total: 823, passed: 823 Details weaselab/conflict-set/pipeline/head This commit looks good Details According to https://cmake.org/cmake/help/latest/command/add_custom_command.html this more accurately matches the intent	2024-04-04 17:03:57 -07:00
Andrew Noyes	90fdcdd51a	Don't update mtime in privatize_symbols_macos.sh It confuses ninja and we see things like the following: ninja explain: stored deps info out of date for 'CMakeFiles/conflict-set-object.dir/ConflictSet.cpp.o' (1712275080328387291 vs 1712275080349012981)	2024-04-04 17:02:51 -07:00