weaselab/conflict-set
1
Fork 1
Code Issues 5 Pull Requests Actions 1 Packages Releases 13 Activity

Assert return values in test_update_zero_should_commit / conflict #50

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-49 into main 2026-06-22 19:29:56 +00:00
Conversation 0 Commits 1 Files Changed 1
+2 -2
weaselbot commented 2026-06-21 16:40:01 +00:00
Member
Copy Link
Copy Source

Closes #49

Closes #49
andrew force-pushed weaselbot/issue-49 from c3c69786fe to 29d0997ca3 2026-06-21 23:29:28 +00:00 Compare
andrew added 1 commit 2026-06-22 18:09:13 +00:00
Assert return values in test_update_zero_should_commit / conflict
CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m22s
Details
CI / pre-commit (pull_request) Successful in 2m13s
Details
CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m36s
Details
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m28s
Details
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m37s
Details
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m27s
Details
CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 4m53s
Details
CI / coverage (pull_request) Successful in 3m37s
Details
60881419b8 
Add the missing [Result.COMMIT] / [Result.CONFLICT] assertions so
that the two regression tests actually verify the expected conflict-set
outcome, not just that the calls do not crash.
andrew force-pushed weaselbot/issue-49 from 29d0997ca3 to 60881419b8 2026-06-22 18:09:13 +00:00 Compare
andrew merged commit 549724f09e into main 2026-06-22 19:29:56 +00:00
andrew deleted branch weaselbot/issue-49 2026-06-22 19:29:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 enhancement
New feature
 investigation
wontfix
This won't be fixed
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
andrew weaselbot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#50