weaselab/conflict-set
1
Fork 1
Code Issues 5 Pull Requests Actions 1 Packages Releases 13 Activity

Set restype=None for void-returning C functions #53

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-46 into main 2026-06-22 01:12:57 +00:00
Conversation 0 Commits 1 Files Changed 1
+4
weaselbot commented 2026-06-21 16:55:55 +00:00
Member
Copy Link
Copy Source

Closes #46

Closes #46
weaselbot marked the pull request as ready for review 2026-06-21 16:56:51 +00:00
andrew added 1 commit 2026-06-21 23:26:52 +00:00
Set restype=None for void-returning C functions in conflict_set.py
CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m28s
Details
CI / pre-commit (pull_request) Successful in 2m14s
Details
CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m39s
Details
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m33s
Details
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m44s
Details
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m32s
Details
CI / release (amd64, ubuntu-latest-amd64) (pull_request) Failing after 4m25s
Details
CI / coverage (pull_request) Failing after 3m20s
Details
742d920aa1 
ConflictSet_check, ConflictSet_addWrites, ConflictSet_setOldestVersion,
and ConflictSet_destroy return void in C, but the Python wrapper left
their ctypes restype at the default c_int. Set restype = None for each
to match the C API contract and avoid undefined behavior from reading
the return register of void functions.
andrew force-pushed weaselbot/issue-46 from 9db772eb71 to 742d920aa1 2026-06-21 23:26:52 +00:00 Compare
andrew merged commit d70e6a2455 into main 2026-06-22 01:12:57 +00:00
andrew deleted branch weaselbot/issue-46 2026-06-22 01:13:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 enhancement
New feature
 investigation
wontfix
This won't be fixed
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
andrew weaselbot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#53