Fix RealDataBench subspan and version API contract violations #61

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-58 into main 2026-06-29 18:50:00 +00:00
Member

Closes #58

Changes in RealDataBench.cpp:

  • Fix std::span::subspan calls to request line.size() - 2 bytes starting at offset 2, instead of line.size(), and guard against lines shorter than the two-byte prefix so we never read past line bounds.
  • Clamp both the per-read readVersion and the setOldestVersion argument to 0, satisfying the non-negative and monotonic version contracts during the first 100 / 10 000 batches.
Closes #58 Changes in `RealDataBench.cpp`: - Fix `std::span::subspan` calls to request `line.size() - 2` bytes starting at offset 2, instead of `line.size()`, and guard against lines shorter than the two-byte prefix so we never read past line bounds. - Clamp both the per-read `readVersion` and the `setOldestVersion` argument to `0`, satisfying the non-negative and monotonic version contracts during the first 100 / 10 000 batches.
weaselbot added 1 commit 2026-06-29 18:01:35 +00:00
Fix RealDataBench subspan and version API contract violations
CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m33s
CI / pre-commit (pull_request) Successful in 2m4s
CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m38s
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m29s
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m38s
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m30s
CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 4m57s
CI / coverage (pull_request) Successful in 3m40s
4fcdc5d7e9
- Use subspan count `line.size() - 2` instead of `line.size()` to avoid reading past the line bounds, and guard lines shorter than the two-byte prefix.
- Clamp `readVersion` and `setOldestVersion` arguments to `0` so the conflict set never receives negative, non-monotonic versions during the warmup phase.

Fixes #58.
andrew scheduled this pull request to auto merge when all checks succeed 2026-06-29 18:40:53 +00:00
andrew merged commit 732d19efa1 into main 2026-06-29 18:50:00 +00:00
andrew deleted branch weaselbot/issue-58 2026-06-29 18:50:00 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#61