weaselab/conflict-set
1
Fork 1
Code Issues 5 Pull Requests Actions 1 Packages Releases 13 Activity

Correct rationale in simd_x86_64.S comment #72

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-71 into main 2026-08-03 04:59:28 +00:00
Conversation 0 Commits 1 Files Changed 1
+4 -3
weaselbot commented 2026-08-03 02:25:21 +00:00
Member
Copy Link
Copy Source

Closes #71

Closes #71
weaselbot requested review from andrew 2026-08-03 02:25:25 +00:00
andrew added 1 commit 2026-08-03 02:37:22 +00:00
Correct rationale in simd_x86_64.S comment
CI / release (arm64, , ubuntu-latest-arm64) (pull_request) Successful in 2m14s
Details
CI / pre-commit (pull_request) Successful in 1m59s
Details
CI / test (-DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, debug) (pull_request) Successful in 3m47s
Details
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m14s
Details
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m13s
Details
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m17s
Details
CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (pull_request) Successful in 5m27s
Details
CI / coverage (pull_request) Successful in 3m42s
Details
0b12a037c4 
The SIMD operations are written in assembly because loading and
operating on indeterminate values is UB in C++ but well-defined in
assembly. msan not tracking the loads is a side effect, not the reason.
Closes #71
andrew force-pushed weaselbot/issue-71 from 79ae91e7d3 to 0b12a037c4 2026-08-03 02:37:22 +00:00 Compare
andrew scheduled this pull request to auto merge when all checks succeed 2026-08-03 02:37:33 +00:00
andrew merged commit bdbac1556d into main 2026-08-03 04:59:28 +00:00
andrew deleted branch weaselbot/issue-71 2026-08-03 04:59:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
bug
Something is not working
 enhancement
New feature
 investigation
wontfix
This won't be fixed
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
andrew weaselbot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#72