weaselab/conflict-set
1
Fork 1
Code Issues 6 Pull Requests Actions 1 Packages Releases 13 Activity

SkipList: don't lower oldestVersion in setOldestVersion #92

Merged
andrew merged 3 commits from weaselbot/conflict-set:weaselbot/issue-87 into main 2026-10-27 19:30:12 +00:00
Conversation 1 Commits 3 Files Changed 3
+10 -5
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 56e0673fc7 - Show all commits
CMakeLists.txt
+10 -5
View File
@@ -182,6 +182,8 @@ endif()
include(CTest) include(CTest)
option(TEST_SKIP_LIST "Run the slow skip list cross-check tests" OFF)
# disable tests if this is being used through e.g. FetchContent # disable tests if this is being used through e.g. FetchContent
if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR AND BUILD_TESTING) if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR AND BUILD_TESTING)
@@ -224,11 +226,14 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR AND BUILD_TESTING)
target_compile_options(driver_skip_list PRIVATE ${TEST_FLAGS}) target_compile_options(driver_skip_list PRIVATE ${TEST_FLAGS})
target_link_libraries(driver_skip_list PRIVATE skip_list) target_link_libraries(driver_skip_list PRIVATE skip_list)
andrew commented 2026-10-27 16:04:56 +00:00
Outdated
Review
Copy link
Copy source

We don't want to run the skip list tests every time by default. That's a waste of time

We don't want to run the skip list tests every time by default. That's a waste of time
# skip list tests, which cross-check SkipList.cpp against ReferenceImpl # Optional cross-check of SkipList.cpp against ReferenceImpl. Opt-in via
foreach(TEST ${CORPUS_TESTS}) # -DTEST_SKIP_LIST=ON, since these are slow.
get_filename_component(hash ${TEST} NAME) if(TEST_SKIP_LIST)
add_test(NAME skip_list_${hash} COMMAND driver_skip_list ${TEST}) foreach(TEST ${CORPUS_TESTS})
endforeach() get_filename_component(hash ${TEST} NAME)
add_test(NAME skip_list_${hash} COMMAND driver_skip_list ${TEST})
endforeach()
endif()
# ad hoc testing # ad hoc testing
add_executable(conflict_set_main ConflictSet.cpp) add_executable(conflict_set_main ConflictSet.cpp)