From 3aa192255e7228014f337e63d35aa7359a9d1fe0 Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Tue, 28 May 2024 14:01:51 -0700
Subject: [PATCH] Identify some FdbVersionedMap bugs

---
 FdbVersionedMap.cpp | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/FdbVersionedMap.cpp b/FdbVersionedMap.cpp
index 6fa08c6..f275761 100644
--- a/FdbVersionedMap.cpp
+++ b/FdbVersionedMap.cpp
@@ -1203,16 +1203,14 @@ struct __attribute__((__visibility__("hidden"))) VersionedMap::Impl {
         }
         versionedData.erase(param1, param2);
         assert(param2 > param1);
-        // assert(
-        //     !versionedData.isClearContaining(versionedData.atLatest(),
-        //     param1));
+        assert(
+            !versionedData.isClearContaining(versionedData.atLatest(), param1));
         versionedData.insert(param1, ValueOrClearToRef::clearTo(param2));
       }
     }
   }
 
   void setOldestVersion(int64_t oldestVersion) {
-    return;
     auto iter = mutationLog.begin();
     while (iter != mutationLog.end() && iter->first <= oldestVersion) {
       for (const auto &m : iter->second.mutations) {
@@ -1238,8 +1236,6 @@ struct __attribute__((__visibility__("hidden"))) VersionedMap::Impl {
     }
     versionedData.forgetVersionsBefore(oldestVersion);
   }
-
-  // TODO
 };
 
 VersionedMap::Impl *internal_makeImpl(int64_t version) {