From 742f1da722eb0244f6c7eca488e1c4f3b2f9ff0a Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Tue, 4 Jun 2024 16:31:19 -0700
Subject: [PATCH] Improve clarity in operator{--,++}

---
 VersionedMap.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/VersionedMap.cpp b/VersionedMap.cpp
index 6ccb4f8..387b462 100644
--- a/VersionedMap.cpp
+++ b/VersionedMap.cpp
@@ -1154,9 +1154,10 @@ VersionedMap::Iterator &VersionedMap::Iterator::operator++() {
     const auto &entry = *impl->map->mm.base[impl->finger.backNode()].entry;
     impl->map->move<std::memory_order_acquire, true>(impl->finger,
                                                      impl->version);
-    if (impl->finger.searchPathSize() > 0) {
-      materializeMutations(impl, &entry, nullptr);
+    if (impl->finger.searchPathSize() == 0) {
+      break;
     }
+    materializeMutations(impl, &entry, nullptr);
   } while (impl->mutationCount == 0);
   impl->mutationIndex = 0;
 
@@ -1208,9 +1209,10 @@ VersionedMap::Iterator &VersionedMap::Iterator::operator--() {
     const Entry *entry = impl->map->mm.base[impl->finger.backNode()].entry;
     impl->map->move<std::memory_order_acquire, false>(impl->finger,
                                                       impl->version);
-    if (impl->finger.searchPathSize() > 0) {
-      materializeMutations(impl, nullptr, entry);
+    if (impl->finger.searchPathSize() == 0) {
+      break;
     }
+    materializeMutations(impl, nullptr, entry);
   } while (impl->mutationCount == 0);
   impl->mutationIndex = impl->mutationCount - 1;
   return *this;