From 2b8f095d27233b338b46b29f584a9f3316943ac3 Mon Sep 17 00:00:00 2001 From: Andrew Noyes Date: Fri, 12 Sep 2025 12:13:50 -0400 Subject: [PATCH] Fix minor issues --- src/reference.hpp | 5 +++-- tests/test_reference.cpp | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/reference.hpp b/src/reference.hpp index ed663dd..8939d28 100644 --- a/src/reference.hpp +++ b/src/reference.hpp @@ -85,7 +85,7 @@ struct ControlBlock { * * Usage: * - Use make_ref() to create new objects - * - Copy/assign to share ownership + * - Use copy() method for explicit sharing of ownership * - Use get(), operator*, operator-> to access the object * - Use operator bool() to check if valid * - Use reset() to release ownership @@ -297,7 +297,8 @@ private: * that might be destroyed by other threads. * * Usage: - * - Create from Ref to observe without owning + * - Create from Ref using as_weak() to observe without owning + * - Use copy() method for explicit copying * - Use lock() to attempt promotion to Ref * - Returns empty Ref if object was already destroyed * - Use reset() to stop observing diff --git a/tests/test_reference.cpp b/tests/test_reference.cpp index 957d478..cab5a26 100644 --- a/tests/test_reference.cpp +++ b/tests/test_reference.cpp @@ -472,7 +472,6 @@ TEST_CASE("Polymorphic edge cases") { // addresses Interface1 *interface1_ptr = multi_ref.get(); Interface2 *interface2_ptr = multi_ref.get(); - MultipleInheritance *multi_ptr = multi_ref.get(); // Verify that pointers are indeed different (demonstrating the issue) CHECK(static_cast(interface1_ptr) !=