Remove ProcessResult

This commit is contained in:
2025-08-19 13:41:26 -04:00
parent e832d8419c
commit 455ab749a6
4 changed files with 11 additions and 43 deletions

View File

@@ -6,12 +6,6 @@
// Forward declaration to avoid circular dependency
struct Connection;
enum class ProcessResult {
Continue, // Keep connection open, continue processing
CloseAfterSend, // Send response then close connection
CloseNow // Close connection immediately
};
/**
* Abstract interface for handling connection data processing.
*
@@ -32,19 +26,17 @@ public:
* @param data Incoming data buffer (may be partial message)
* @param conn_ptr Unique pointer to connection - handler can take ownership
* by releasing it
* @return ProcessResult indicating how to handle the connection
*
* Implementation should:
* - Parse incoming data using arena allocator when needed
* - Use conn_ptr->appendMessage() to queue response data
* - Return appropriate ProcessResult for connection management
* - Handle partial messages and streaming protocols appropriately
* - Can take ownership by calling conn_ptr.release() to pass to other threads
* - If ownership is taken, handler must call Server::releaseBackToServer()
* when done
*/
virtual ProcessResult process_data(std::string_view data,
std::unique_ptr<Connection> &conn_ptr) = 0;
virtual void process_data(std::string_view data,
std::unique_ptr<Connection> &conn_ptr) = 0;
/**
* Called when a new connection is established.
@@ -53,8 +45,6 @@ public:
*
* Use this for:
* - Connection-specific initialization
* - Sending greeting messages
* - Setting up connection state
*/
virtual void on_connection_established(Connection &) {}
@@ -65,8 +55,6 @@ public:
*
* Use this for:
* - Cleanup of connection-specific resources
* - Logging connection statistics
* - Finalizing protocol state
*/
virtual void on_connection_closed(Connection &) {}
};