weaselab/weaseldb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove has_read_version_been_set_ from CommitRequest

Browse Source
This commit is contained in:
Andrew Noyes
2025-08-17 14:09:55 -04:00
parent fa2a2e4427
commit 67ddcd0fc8
4 changed files with 22 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/json_commit_request_parser.cpp
View File

@@ -423,6 +423,7 @@ void JsonCommitRequestParser::handle_completed_number(std::string_view s) {
auto result = std::from_chars(s.data(), s.data() + s.size(), version);
if (result.ec == std::errc{}) {
current_request_->set_read_version(version);
ctx.has_read_version_been_set = true;
} else {
ctx.parse_error = "Invalid number format for read_version field";
}
@@ -456,7 +457,7 @@ bool JsonCommitRequestParser::parse(CommitRequest &request, char *data,
finish_streaming_parse(request);
return !has_parse_error() && !request.leader_id().empty() &&
request.has_read_version_been_set();
parser_context_->has_read_version_been_set;
}
bool JsonCommitRequestParser::begin_streaming_parse(CommitRequest &request) {
@@ -469,6 +470,7 @@ bool JsonCommitRequestParser::begin_streaming_parse(CommitRequest &request) {
parser_context_->reset_arena_memory(&request.arena());
parser_context_->parse_error = nullptr;
parser_context_->parse_complete = false;
parser_context_->has_read_version_been_set = false;
}
if (json_parser_) {
@@ -544,4 +546,8 @@ bool JsonCommitRequestParser::has_parse_error() const {
const char *JsonCommitRequestParser::get_parse_error() const {
return parser_context_ ? parser_context_->parse_error : nullptr;
}
bool JsonCommitRequestParser::has_read_version_been_set() const {
return parser_context_ && parser_context_->has_read_version_been_set;
}