From 6f421629aaefd7d61fa51bfeab1bbcdec5003df5 Mon Sep 17 00:00:00 2001 From: Andrew Noyes Date: Mon, 15 Sep 2025 22:51:41 -0400 Subject: [PATCH] Add comments to avoid blocking in sequence and resolve stages --- src/commit_pipeline.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/commit_pipeline.cpp b/src/commit_pipeline.cpp index f4b3575..d3ac123 100644 --- a/src/commit_pipeline.cpp +++ b/src/commit_pipeline.cpp @@ -79,6 +79,7 @@ void CommitPipeline::submit_batch(std::span entries) { // Guard destructor publishes batch to stage 0 } +// AVOID BLOCKING IN THIS STAGE! void CommitPipeline::run_sequence_stage() { int64_t next_version = 1; @@ -157,6 +158,7 @@ void CommitPipeline::run_sequence_stage() { } } +// AVOID BLOCKING IN THIS STAGE! void CommitPipeline::run_resolve_stage() { for (int shutdowns_received = 0; shutdowns_received < 2;) { auto guard = pipeline_.acquire<1, 0>(/*maxBatch*/ 1);