From 7006012aebba2dcab81abee59625e93b51d06457 Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Tue, 2 Sep 2025 13:01:02 -0400
Subject: [PATCH] Fix stack-use-after-scope

---
 tests/test_metric.cpp | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/tests/test_metric.cpp b/tests/test_metric.cpp
index 0dc805d..fdfd6e1 100644
--- a/tests/test_metric.cpp
+++ b/tests/test_metric.cpp
@@ -275,11 +275,9 @@ TEST_CASE("callback-based metrics") {
   auto gauge_family = metric::create_gauge("callback_gauge", "Callback gauge");
 
   SUBCASE("counter callback") {
-    std::atomic<double> counter_value{42.0};
 
-    counter_family.register_callback(
-        {{"type", "callback"}},
-        [&counter_value]() { return counter_value.load(); });
+    counter_family.register_callback({{"type", "callback"}},
+                                     []() { return 42.0; });
 
     // Callback should be called during render
     ArenaAllocator arena;
@@ -288,11 +286,8 @@ TEST_CASE("callback-based metrics") {
   }
 
   SUBCASE("gauge callback") {
-    std::atomic<double> gauge_value{123.5};
-
-    gauge_family.register_callback({{"type", "callback"}}, [&gauge_value]() {
-      return gauge_value.load();
-    });
+    gauge_family.register_callback({{"type", "callback"}},
+                                   []() { return 123.5; });
 
     ArenaAllocator arena;
     auto output = metric::render(arena);