From c0242317ed00a00568b07b92321f9ee8fcaebc11 Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Sun, 24 Aug 2025 11:00:20 -0400
Subject: [PATCH] on_post_batch -> on_batch_complete

---
 design.md                  | 2 +-
 src/connection_handler.hpp | 4 ++--
 src/http_handler.cpp       | 3 ++-
 src/http_handler.hpp       | 3 ++-
 src/server.cpp             | 4 ++--
 5 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/design.md b/design.md
index 424e727..2a70143 100644
--- a/design.md
+++ b/design.md
@@ -395,7 +395,7 @@ public:
     proto_data->process(data);
   }
 
-  void on_post_batch(std::span<std::unique_ptr<Connection>> batch) override {
+  void on_batch_complete(std::span<std::unique_ptr<Connection>> batch) override {
     // Process a batch of connections
     for (auto& conn_ptr : batch) {
       if (conn_ptr) {
diff --git a/src/connection_handler.hpp b/src/connection_handler.hpp
index 6dcb347..9a992fe 100644
--- a/src/connection_handler.hpp
+++ b/src/connection_handler.hpp
@@ -107,6 +107,6 @@ public:
    *
    * @param batch A span of unique_ptrs to the connections in the batch.
    */
-  virtual void on_post_batch(std::span<std::unique_ptr<Connection>> /*batch*/) {
-  }
+  virtual void
+  on_batch_complete(std::span<std::unique_ptr<Connection>> /*batch*/) {}
 };
diff --git a/src/http_handler.cpp b/src/http_handler.cpp
index 7e758bf..d582a5e 100644
--- a/src/http_handler.cpp
+++ b/src/http_handler.cpp
@@ -50,7 +50,8 @@ void HttpHandler::on_write_buffer_drained(
   on_connection_established(*conn_ptr);
 }
 
-void HttpHandler::on_post_batch(std::span<std::unique_ptr<Connection>> batch) {
+void HttpHandler::on_batch_complete(
+    std::span<std::unique_ptr<Connection>> batch) {
   int readyCount = 0;
   for (int i = 0; i < int(batch.size()); ++i) {
     readyCount += batch[i] && batch[i]->outgoingBytesQueued() > 0;
diff --git a/src/http_handler.hpp b/src/http_handler.hpp
index 397a899..009f869 100644
--- a/src/http_handler.hpp
+++ b/src/http_handler.hpp
@@ -103,7 +103,8 @@ struct HttpHandler : ConnectionHandler {
   void on_data_arrived(std::string_view data,
                        std::unique_ptr<Connection> &conn_ptr) override;
   void on_write_buffer_drained(std::unique_ptr<Connection> &conn_ptr) override;
-  void on_post_batch(std::span<std::unique_ptr<Connection>> /*batch*/) override;
+  void on_batch_complete(
+      std::span<std::unique_ptr<Connection>> /*batch*/) override;
 
   // Route parsing (public for testing)
   static HttpRoute parseRoute(std::string_view method, std::string_view url);
diff --git a/src/server.cpp b/src/server.cpp
index 3081028..36cea2c 100644
--- a/src/server.cpp
+++ b/src/server.cpp
@@ -535,8 +535,8 @@ void Server::process_connection_batch(
     }
   }
 
-  // Call post-batch handler - handlers can take ownership here
-  handler_.on_post_batch(batch);
+  // Call batch complete handler - handlers can take ownership here
+  handler_.on_batch_complete(batch);
 
   // Transfer all remaining connections back to epoll
   for (auto &conn_ptr : batch) {