From ed84e4b54ca32f30f7b8a744e9b90bf0f28934e9 Mon Sep 17 00:00:00 2001
From: Andrew Noyes <andrew@weaselab.dev>
Date: Sun, 17 Aug 2025 15:41:51 -0400
Subject: [PATCH] Fix debug warnings

---
 benchmarks/bench_parser_comparison.cpp | 10 +++-------
 src/json_commit_request_parser.hpp     |  4 +---
 2 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/benchmarks/bench_parser_comparison.cpp b/benchmarks/bench_parser_comparison.cpp
index fd9f50b..99c3027 100644
--- a/benchmarks/bench_parser_comparison.cpp
+++ b/benchmarks/bench_parser_comparison.cpp
@@ -32,7 +32,7 @@ public:
     return newPtr;
   }
 
-  static void Free(void *ptr) {
+  static void Free(void *) {
     // Arena allocators don't free individual allocations
   }
 
@@ -106,9 +106,7 @@ public:
     return true;
   }
   bool Double(double) { return true; }
-  bool RawNumber(const char *str, rapidjson::SizeType length, bool copy) {
-    return Uint64(std::strtoull(str, nullptr, 10));
-  }
+  bool RawNumber(const char *, rapidjson::SizeType, bool) { abort(); }
 
   bool String(const char *str, rapidjson::SizeType length, bool) {
     std::string_view value = store_string(str, length);
@@ -272,9 +270,7 @@ public:
     return true;
   }
   bool Double(double) { return true; }
-  bool RawNumber(const char *str, rapidjson::SizeType length, bool copy) {
-    return Uint64(std::strtoull(str, nullptr, 10));
-  }
+  bool RawNumber(const char *, rapidjson::SizeType, bool) { abort(); }
 
   bool String(const char *str, rapidjson::SizeType length, bool) {
     std::string value(str, length);
diff --git a/src/json_commit_request_parser.hpp b/src/json_commit_request_parser.hpp
index f585e30..7ab1484 100644
--- a/src/json_commit_request_parser.hpp
+++ b/src/json_commit_request_parser.hpp
@@ -55,7 +55,6 @@ private:
     ArenaString current_key;
     ArenaString current_string;
     ArenaString current_number;
-    bool in_key = false;
     const char *parse_error = nullptr;
     bool parse_complete = false;
     bool has_read_version_been_set = false;
@@ -82,7 +81,6 @@ private:
       current_key = ArenaString{ArenaStlAllocator<char>(arena)};
       current_string = ArenaString{ArenaStlAllocator<char>(arena)};
       current_number = ArenaString{ArenaStlAllocator<char>(arena)};
-      in_key = false;
       current_precondition = {};
       current_operation = {};
       precondition_type = ArenaString{ArenaStlAllocator<char>(arena)};
@@ -152,4 +150,4 @@ private:
   void handle_completed_string(std::string_view s);
   void handle_completed_number(std::string_view s);
   void on_complete();
-};
\ No newline at end of file
+};