Merge pull request 'Fix schemagen integer parser rejecting zero with negative exponents' (#57) from weaselbot/weaseljson:weaselbot/issue-56 into main
CI / pre-commit (push) Successful in 52s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (push) Successful in 58s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (push) Successful in 49s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (push) Successful in 1m40s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (push) Successful in 1m29s
CI / pre-commit (push) Successful in 52s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (push) Successful in 58s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (push) Successful in 49s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (push) Successful in 1m40s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (push) Successful in 1m29s
Reviewed-on: #57
This commit was merged in pull request #57.
This commit is contained in:
@@ -592,6 +592,13 @@ class SchemagenIntegerBoundaryTest(unittest.TestCase):
|
|||||||
("123.0", "WeaselJson_OK", 123),
|
("123.0", "WeaselJson_OK", 123),
|
||||||
("9e18", "WeaselJson_OK", 9000000000000000000),
|
("9e18", "WeaselJson_OK", 9000000000000000000),
|
||||||
("10e18", "WeaselJson_REJECT", 0),
|
("10e18", "WeaselJson_REJECT", 0),
|
||||||
|
# Issue #56: zero written with a negative exponent must be accepted.
|
||||||
|
("0e-1", "WeaselJson_OK", 0),
|
||||||
|
("0e-2", "WeaselJson_OK", 0),
|
||||||
|
("0.0e-2", "WeaselJson_OK", 0),
|
||||||
|
("-0e-2", "WeaselJson_OK", 0),
|
||||||
|
("0e-20", "WeaselJson_OK", 0),
|
||||||
|
("0.000e-5", "WeaselJson_OK", 0),
|
||||||
]
|
]
|
||||||
cases_src = self._build_cases_array("root", cases)
|
cases_src = self._build_cases_array("root", cases)
|
||||||
harness = textwrap.dedent(
|
harness = textwrap.dedent(
|
||||||
@@ -634,6 +641,9 @@ class SchemagenIntegerBoundaryTest(unittest.TestCase):
|
|||||||
('{"age":2.0}', "WeaselJson_OK", 2),
|
('{"age":2.0}', "WeaselJson_OK", 2),
|
||||||
('{"age":0.0001e4}', "WeaselJson_OK", 1),
|
('{"age":0.0001e4}', "WeaselJson_OK", 1),
|
||||||
('{"age":0.001}', "WeaselJson_REJECT", 0),
|
('{"age":0.001}', "WeaselJson_REJECT", 0),
|
||||||
|
# Issue #56: zero written with a negative exponent must be accepted.
|
||||||
|
('{"age":0e-2}', "WeaselJson_OK", 0),
|
||||||
|
('{"age":-0e-20}', "WeaselJson_OK", 0),
|
||||||
(
|
(
|
||||||
'{"age":-9223372036854775808.0}',
|
'{"age":-9223372036854775808.0}',
|
||||||
"WeaselJson_OK",
|
"WeaselJson_OK",
|
||||||
|
|||||||
@@ -1058,10 +1058,10 @@ private:
|
|||||||
++trim;
|
++trim;
|
||||||
}}
|
}}
|
||||||
int64_t finalExp = exp - fracDigits + trim;
|
int64_t finalExp = exp - fracDigits + trim;
|
||||||
if (finalExp < 0) return false;
|
|
||||||
size_t leadingZeros = 0;
|
size_t leadingZeros = 0;
|
||||||
while (leadingZeros < digits.size() && digits[leadingZeros] == '0') ++leadingZeros;
|
while (leadingZeros < digits.size() && digits[leadingZeros] == '0') ++leadingZeros;
|
||||||
if (leadingZeros == digits.size()) {{ out = 0; return true; }}
|
if (leadingZeros == digits.size()) {{ out = 0; return true; }}
|
||||||
|
if (finalExp < 0) return false;
|
||||||
if (leadingZeros > 0) digits.erase(0, leadingZeros);
|
if (leadingZeros > 0) digits.erase(0, leadingZeros);
|
||||||
|
|
||||||
constexpr uint64_t kMaxNeg = 9223372036854775808ULL;
|
constexpr uint64_t kMaxNeg = 9223372036854775808ULL;
|
||||||
|
|||||||
Reference in New Issue
Block a user