schemagen: reject absent additionalProperties
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 57s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 50s
CI / pre-commit (pull_request) Successful in 52s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m41s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m29s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 57s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 50s
CI / pre-commit (pull_request) Successful in 52s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m41s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m29s
Per the README contract, an object schema without an explicit `additionalProperties` was documented as rejected at generation time, but the code defaulted it to `false` and silently generated a strict parser that rejects valid documents with extra properties. Make the code match the documented contract by raising GenError when `additionalProperties` is absent, with a clear message instructing the author to set it explicitly to false. Update the README prose section to list absent additionalProperties alongside true, and fix existing schemas and tests to declare additionalProperties explicitly. Closes #55
This commit is contained in:
@@ -417,7 +417,13 @@ class Builder:
|
||||
tobj = TObj(name)
|
||||
if defname is not None:
|
||||
self._building[defname] = (tobj, nullable)
|
||||
ap = node.get("additionalProperties", False)
|
||||
ap = node.get("additionalProperties", None)
|
||||
if ap is None:
|
||||
raise GenError(
|
||||
"additionalProperties is required for object schemas; set it "
|
||||
"explicitly to false to reject unknown keys (absent "
|
||||
"additionalProperties is not supported)"
|
||||
)
|
||||
if ap is True:
|
||||
raise GenError("additionalProperties: true is not supported")
|
||||
if isinstance(ap, dict):
|
||||
|
||||
Reference in New Issue
Block a user