Merge pull request 'schemagen: handle WeaselJsonParser_create failure in RootBuilder' (#46 ) from weaselbot/weaseljson:weaselbot/issue-36 into main

Reviewed-on: #46
schemagen: handle WeaselJsonParser_create failure in RootBuilder
2026-06-30 15:35:20 +00:00 · 2026-06-30 11:26:59 -04:00
2 changed files with 13 additions and 0 deletions
@@ -68,6 +68,15 @@ int main() {
    expectReject(json, "unknown key in strict root");
  }

+  // ---- invalid stack size is rejected without crashing ----
+  {
+    RootBuilder b(-1);
+    char buf[] = "null";
+    WeaselJsonStatus s = b.feed(buf, sizeof(buf) - 1);
+    CHECK(s == WeaselJson_REJECT);
+    printf("ok   invalid stack size rejected, not crashed\n");
+  }
+
  {
    std::string json = R"({
      "name": "Ada É",
@@ -892,6 +892,10 @@ public:
  explicit RootBuilder(int stackSize = 1024) {{
    cb_ = makeCallbacks();
    parser_ = WeaselJsonParser_create(stackSize, &cb_, this, 0);
+    if (!parser_) {{
+      error_ = true;
+      return;
+    }}
 {self._ctor_body()}
  }}
  ~RootBuilder() {{ if (parser_) WeaselJsonParser_destroy(parser_); }}
Author	SHA1	Message	Date
andrew	241c29073b	Merge pull request 'schemagen: handle WeaselJsonParser_create failure in RootBuilder' (#46 ) from weaselbot/weaseljson:weaselbot/issue-36 into main CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (push) Successful in 54s Details CI / pre-commit (push) Successful in 51s Details CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (push) Successful in 50s Details CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (push) Successful in 1m33s Details CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (push) Successful in 1m25s Details Reviewed-on: #46	2026-06-30 15:35:20 +00:00
weaselbot	abeaae7ed7	schemagen: handle WeaselJsonParser_create failure in RootBuilder CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 51s Details CI / pre-commit (pull_request) Successful in 53s Details CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 51s Details CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m34s Details CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m27s Details If WeaselJsonParser_create returns nullptr (e.g. negative stack size or allocation failure), set the existing error_ flag so that subsequent feed()/finish() calls return WeaselJson_REJECT instead of dereferencing the null parser_. Also add a regression test in test_gen.cpp that constructs a RootBuilder with an invalid stack size and verifies it rejects without crashing. Closes #36	2026-06-30 11:26:59 -04:00