Compare commits

..
1 Commits
Author SHA1 Message Date
weaselbot 5e462f1477 make WeaselJson_OVERFLOW a terminal state like WeaselJson_REJECT
CI / pre-commit (pull_request) Successful in 53s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 54s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 51s
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m35s
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m32s
When a parse step returned WeaselJson_OVERFLOW, the pushdown stack was
left corrupted (frames had been popped before the failing push), but the
overflow status was not made sticky the way WeaselJson_REJECT is. A
subsequent end-of-data call WeaselJsonParser_parse(parser, nullptr, 0)
could then dispatch through the corrupted stack and return WeaselJson_OK,
accepting an incomplete, invalid too-deeply-nested document as valid JSON.

Add an `overflowed` flag, set it whenever a continuation returns
WeaselJson_OVERFLOW, and short-circuit parse() to return
WeaselJson_OVERFLOW on every subsequent call. reset() clears the flag so a
reused parser can accept a different document. This mirrors the existing
stickiness handling for WeaselJson_REJECT.

Closes #52
2026-07-13 16:07:36 -04:00
+9 -19
View File
@@ -139,8 +139,7 @@ struct Parser3 {
stackPtr = stack();
std::ignore = push({N_VALUE, N_WHITESPACE, T_EOF});
inKey = false;
rejected = false;
overflowed = false;
terminalStatus = WeaselJson_OK;
utf8Codepoint = 0;
utf16Surrogate = 0;
minCodepoint = 0;
@@ -163,8 +162,7 @@ struct Parser3 {
NumDfa numDfa;
Utf8Dfa strDfa;
bool inKey = false;
bool rejected = false;
bool overflowed = false;
WeaselJsonStatus terminalStatus = WeaselJson_OK;
#ifndef HAS_MUSTTAIL
char *stashBufForTrampoline;
@@ -1072,16 +1070,12 @@ constexpr inline struct ContinuationTable {
inline WeaselJsonStatus Parser3::parse(char *buf, int len) {
this->dataBegin = this->writeBuf = buf;
if (this->rejected) [[unlikely]] {
return WeaselJson_REJECT;
}
if (this->overflowed) [[unlikely]] {
return WeaselJson_OVERFLOW;
if (this->terminalStatus != WeaselJson_OK) [[unlikely]] {
return this->terminalStatus;
}
if (len < 0) [[unlikely]] {
this->rejected = true;
this->terminalStatus = WeaselJson_REJECT;
return WeaselJson_REJECT;
}
@@ -1091,10 +1085,8 @@ inline WeaselJsonStatus Parser3::parse(char *buf, int len) {
// range.
ContinuationStatus status =
symbolTables.continuations[top()](this, buf, buf + len);
if (status == WeaselJson_REJECT) {
this->rejected = true;
} else if (status == WeaselJson_OVERFLOW) {
this->overflowed = true;
if (status == WeaselJson_REJECT || status == WeaselJson_OVERFLOW) {
this->terminalStatus = WeaselJsonStatus(status);
}
return WeaselJsonStatus(status);
#else
@@ -1103,10 +1095,8 @@ inline WeaselJsonStatus Parser3::parse(char *buf, int len) {
while ((result = symbolTables.continuations[top()](
this, stashBufForTrampoline, buf + len)) == kBounce)
;
if (result == WeaselJson_REJECT) {
this->rejected = true;
} else if (result == WeaselJson_OVERFLOW) {
this->overflowed = true;
if (result == WeaselJson_REJECT || result == WeaselJson_OVERFLOW) {
this->terminalStatus = WeaselJsonStatus(result);
}
return WeaselJsonStatus(result);
#endif