weaselab/weaseljson
2
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Python bindings: add missing on_key_data callback #7

Merged
andrew merged 2 commits from weaselbot/weaseljson:weaselbot/issue-6 into main 2026-06-18 15:01:56 +00:00
Conversation 0 Commits 2 Files Changed 3
+120 -11
weaselbot commented 2026-06-18 14:13:12 +00:00
Member
Copy Link
Copy Source

Closes #6

Closes #6
weaselbot added 1 commit 2026-06-18 14:13:13 +00:00
Python bindings: add missing on_key_data callback
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 52s
Details
CI / pre-commit (pull_request) Failing after 52s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 49s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m30s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m22s
Details
320e03f280 
- Insert `on_key_data` into `WeaselJsonCallbacks._fields_` in the same
  order as the C struct (`on_string_data`, then `on_key_data`, then
  `on_begin_array`).
- Add `on_key_data(self, data, done)` to `WeaselJsonCallbacksBase`.
- Add a ctypes wrapper for `on_key_data` and wire it into the global
  `c_callbacks` object.
- Guard the demo code at the bottom of `weaseljson.py` under
  `if __name__ == "__main__"` so the module is safe to import.
- Add `test_python_bindings.py` and a CMake `python_bindings` test that
  verify object keys are delivered to `on_key_data` while string values
  still go to `on_string_data`.

Closes #6
weaselbot added 1 commit 2026-06-18 14:55:23 +00:00
Apply formatting fixes from cmake-format and black
CI / pre-commit (pull_request) Successful in 51s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-arm64, ubuntu-latest-arm64, true) (pull_request) Successful in 51s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-arm64, ubuntu-latest-arm64, false) (pull_request) Successful in 50s
Details
CI / build (-DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++, clang-amd64, ubuntu-latest-amd64, true) (pull_request) Successful in 1m28s
Details
CI / build (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc-amd64, ubuntu-latest-amd64, false) (pull_request) Successful in 1m22s
Details
7ea2e2362e 
Reformat the add_test call in CMakeLists.txt and collapse a
multi-line json.dumps() call in test_python_bindings.py so that
pre-commit passes.
andrew merged commit 7a8e5f84f2 into main 2026-06-18 15:01:56 +00:00
andrew deleted branch weaselbot/issue-6 2026-06-18 15:01:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/weaseljson#7