weaselbot/conflict-set
1
Fork 0
forked from weaselab/conflict-set
Code Pull Requests Activity

Enable the skip list corpus tests by default

Browse Source 
driver_skip_list checks SkipList.cpp against ReferenceImpl, but its tests
were disabled, so the implementation diverged from the documented API
without anything noticing. The corpus tests pass in Debug and Release
builds, so run them like the other implementations' tests.
This commit is contained in:
weaselbot committed 2026-10-26 18:46:02 -04:00
1 parent b22d5f4816
commit 8b6389236a
1 file changed
+5 -7
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+5 -7
View File
@@ -224,13 +224,11 @@ if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR AND BUILD_TESTING)
target_compile_options(driver_skip_list PRIVATE ${TEST_FLAGS}) target_compile_options(driver_skip_list PRIVATE ${TEST_FLAGS})
target_link_libraries(driver_skip_list PRIVATE skip_list) target_link_libraries(driver_skip_list PRIVATE skip_list)
# enable to test skip list # skip list tests, which cross-check SkipList.cpp against ReferenceImpl
if(0) foreach(TEST ${CORPUS_TESTS})
foreach(TEST ${CORPUS_TESTS}) get_filename_component(hash ${TEST} NAME)
get_filename_component(hash ${TEST} NAME) add_test(NAME skip_list_${hash} COMMAND driver_skip_list ${TEST})
add_test(NAME skip_list_${hash} COMMAND driver_skip_list ${TEST}) endforeach()
endforeach()
endif()
# ad hoc testing # ad hoc testing
add_executable(conflict_set_main ConflictSet.cpp) add_executable(conflict_set_main ConflictSet.cpp)