weaselbot/conflict-set
1
Fork 0
forked from weaselab/conflict-set
Code Pull Requests Activity

Remove test_fixup_256, which cannot detect the bug

Browse Source 
Every child of the Node256 in test_fixup_256 is written at the same
version, so max(childMaxVersion[0..15]) and max(maxOfMax) agree and the
buggy code passes. test_fixup_256_heterogeneous_versions covers the same
Node256-under-a-range-end shape with distinct versions, so keep only that.
This commit is contained in:
weaselbot committed 2026-10-27 14:10:36 -04:00
1 parent 3d3184ef5f
commit c94e9aaee6
1 file changed
-12
Download Patch File Download Diff File Expand all files Collapse all files
test_conflict_set.py
-12
View File
@@ -222,18 +222,6 @@ def test_merge_child_node48():
cs.addWrites(1, write(b"\x00" * 8, b"\x00" * 10)) cs.addWrites(1, write(b"\x00" * 8, b"\x00" * 10))
def test_fixup_256():
# All children are written at the same version, so this test passes even
# if fixupMaxVersion only considers some of them. See
# test_fixup_256_heterogeneous_versions for that case.
with DebugConflictSet() as cs:
cs.addWrites(0, write(bytes([1])))
for i in range(256):
cs.addWrites(1, write(bytes([1, i])))
cs.addWrites(2, write(bytes([0]), bytes([1])))
cs.check(read(0, bytes([1]), bytes([2])))
def test_fixup_256_heterogeneous_versions(): def test_fixup_256_heterogeneous_versions():
# Regression test for issue #89: recomputing the maxVersion of a Node256 # Regression test for issue #89: recomputing the maxVersion of a Node256
# must consider all of its children, not just those with an index < 16. # must consider all of its children, not just those with an index < 16.