andrew
3a82d90914
Work around arm64 clang codegen issues breaking CI
...
Disable preserve_none under ASan on aarch64: every clang tested (20,
21, trunk 22) miscompiles the continuation chains with that
combination, crashing ~97% of fuzz corpus tests. The chains still work
with the default calling convention. See #38 .
Mark the masked Node3 scan results defined for valgrind on aarch64:
clang 21+ lowers the in-bounds tests through flags+csel, which
memcheck models imprecisely, tainting bits the mask provably clears.
See #39 .
Skip valgrind tests in the arm64 release job, since -DNVALGRIND
compiles out the client requests the workaround relies on.
Both issues track filing upstream bugs.
2026-06-12 16:35:57 -04:00
andrew
2642d453dc
Remove unnecessary branch for interleaved range writes
2024-12-11 21:53:44 -08:00
andrew
7166811387
Fix condition checking for erasing the root
2024-11-21 17:49:54 -08:00
andrew
81323972aa
Remove "memcpy common section to next node"
...
Do it in a simpler, more robust/type safe way
2024-11-21 16:47:05 -08:00
andrew
8694ba8b6a
Remove unused field
2024-11-21 16:35:10 -08:00
andrew
0cea5565b5
Add artificial root parent and stop plumbing impl everywhere
2024-11-21 16:32:13 -08:00
andrew
972f16ed8f
Remove Node::endOfRange
...
This should simplify storing leaves directly
2024-11-21 11:55:30 -08:00
andrew
2412684316
childMaxVersion memory needs to be defined
...
Also remove some dead code, and only memset children to 0 for Node256.
Other nodes detect absence of children other ways.
2024-11-21 10:35:05 -08:00
andrew
8251631087
Fix some unintentional generic usages of getChildAndMaxVersion
2024-11-20 21:50:48 -08:00
andrew
90fb2a9542
Remove some usages of generic getFirstChild
2024-11-20 21:43:47 -08:00
andrew
7c01f8ba0f
Remove some usages of maxVersion
2024-11-20 21:24:59 -08:00
andrew
0df2db7f8a
Remove some bad unlikely annotations found by -Wmisexpect
...
Using a profile from server_bench
2024-11-20 19:06:50 -08:00
andrew
e125b599b5
Remove freeList, min/max capacity tracking
...
The freelist doesn't seem to get a good hit rate. Policies other than
capacity = minCapacity did not improve the rate we were resizing nodes,
but did increase memory usage, so get rid of that too. Add a
nodes_resized_total counter.
2024-11-20 14:45:56 -08:00
andrew
3f4d3b685a
More valgrind annotations
2024-11-20 13:36:30 -08:00
andrew
4198b8b090
Some prep for leafs-in-parents
2024-11-20 12:20:11 -08:00
andrew
8757d2387c
Call prefetch within TaggedNodePointer::getType
...
Instead of at every call site
2024-11-20 12:07:32 -08:00
andrew
4a22b95d53
Remove state machine transitions "from" Node0
...
Those aren't used
2024-11-20 11:46:45 -08:00
andrew
03d6c7e471
Allocate maxCapacity instead of minCapacity
2024-11-19 16:13:57 -08:00
andrew
ceecc62a63
Disable freelist for macos
...
It's faster on my mac m1 without the freelist
2024-11-19 14:28:15 -08:00
andrew
e5b9c03e77
Restore change that hurt codegen
...
I don't understand, but this is necessary for good codegen somehow
2024-11-18 14:29:55 -08:00
andrew
ee5a84cd7b
Remove dead stores
2024-11-15 17:03:29 -08:00
andrew
77262ee2d3
Fix some grammar in a comment
2024-11-15 16:47:31 -08:00
andrew
2777e016ff
Be more consistent about TaggedNodePointer vs Node*
2024-11-15 16:30:05 -08:00
andrew
661ffcd843
Explain purpose for prefetches in getFirstChild
2024-11-15 16:29:42 -08:00
andrew
3a34d3cecb
Minor style improvements
2024-11-15 16:29:17 -08:00
andrew
189c73e3bd
Reduce Node3 size by 8
2024-11-15 15:53:18 -08:00
andrew
f5ec9f726a
Remove getFirstChildExists
...
Once we know the type, for Node3 and higher we know the first child
exists anyway
2024-11-15 13:05:11 -08:00
andrew
552fc11c5d
Prefetch second child to improve scan performance
2024-11-15 12:45:01 -08:00
andrew
08958d4109
Remove the reverse step for saving scan search path
2024-11-14 16:27:25 -08:00
andrew
b78e817e24
Only set HAS_AVX for x86_64
2024-11-12 18:16:30 -08:00
andrew
665a9313a4
Valgrind annotations for new free list
2024-11-12 18:11:09 -08:00
andrew
a92271a205
Build with -Wunused-variable
2024-11-12 17:50:27 -08:00
andrew
0dbfb4deae
Detect simd headers in c++ instead of cmake
2024-11-12 17:50:27 -08:00
andrew
b37feb58dd
Require musttail and preserve_none for interleaved
2024-11-12 17:50:27 -08:00
andrew
f85b92f8db
Improve next{Physical,Logical} codegen
2024-11-09 13:21:36 -08:00
andrew
3c44614311
Allocate from freelist with min/max capacity constraints
2024-11-08 21:35:13 -08:00
andrew
9c1ac3702e
Move index closer to start of Node{3,16}
...
This should slightly improve cache hit rate
2024-11-08 20:54:00 -08:00
andrew
4494359ca2
Make insert_iterations for interleaved writes more closely match
2024-11-04 14:46:30 -08:00
andrew
4eaad39294
Maintain capacity invariant strictly
2024-11-04 13:43:02 -08:00
andrew
d6269c5b7c
Use interleaved even if preserve_none is missing
2024-11-01 15:12:59 -07:00
andrew
821179b8de
Remove dead code
2024-11-01 13:48:32 -07:00
andrew
681a961289
Dispatch on type pairs for end iter
2024-11-01 13:45:41 -07:00
andrew
c73a3da14c
Dispatch on type pairs for begin iter
2024-11-01 12:46:36 -07:00
andrew
5153d25cce
Dispatch on type pairs for common prefix iter
2024-11-01 12:06:48 -07:00
andrew
d2ec4e7fae
Fix use of wrong member in endIter
2024-11-01 11:17:26 -07:00
andrew
ec1c1cf43f
Run gc less frequently
...
But still run it to account for the version potentially increasing
2024-10-31 15:35:00 -07:00
andrew
eaad0c69a7
Store Result* pointer instead of index
2024-10-31 12:59:36 -07:00
andrew
309e6ab816
Dispatch on pair of types
2024-10-30 22:59:00 -07:00
andrew
0cce9df8a8
Use constexpr int instead of sizeof
2024-10-30 15:36:46 -07:00
andrew
0df09743da
Don't assign to nextRangeWrite twice
2024-10-30 15:33:40 -07:00
andrew