andrew
0 Followers · 0 Following
  • Joined on 2023-03-22
Repositories Projects Packages Public Activity Watched Repositories
andrew suggested changes for weaselab/conflict-set#65 2026-07-13 20:43:19 +00:00
Fix null pointers passed to memcmp/memcpy in skip_list

I missed that there was a downstream length comparison. First commit was fine. Please remove the last commit

andrew suggested changes for weaselab/weaseljson#53 2026-07-13 19:54:15 +00:00
make WeaselJson_OVERFLOW a terminal state like WeaselJson_REJECT
andrew commented on pull request weaselab/weaseljson#53 2026-07-13 19:54:15 +00:00
make WeaselJson_OVERFLOW a terminal state like WeaselJson_REJECT

We should just have one "sticky status" and if it's non-zero return that. That way we don't need separate branches for rejected and overflowed

andrew suggested changes for weaselab/conflict-set#65 2026-07-13 19:51:47 +00:00
Fix null pointers passed to memcmp/memcpy in skip_list
andrew commented on pull request weaselab/conflict-set#65 2026-07-13 19:51:47 +00:00
Fix null pointers passed to memcmp/memcpy in skip_list

If one of them is non-empty, this could compare them incorrectly

andrew commented on issue weaselab/conflict-set#64 2026-07-13 15:29:55 +00:00
skip_list: addWrites passes null pointers to memcmp (undefined behavior) on every call

The skip_list is not shipped. It's test only. Let's fix it anyway though

andrew deleted branch weaselbot/issue-62 from weaselbot/conflict-set 2026-07-08 13:58:52 +00:00
andrew pushed to main at weaselab/conflict-set 2026-07-08 13:58:49 +00:00
d479f16204 Merge pull request 'Return 0 instead of -1 from hash_table getBytes()' (#63) from weaselbot/conflict-set:weaselbot/issue-62 into main
dee3a8f640 Return 0 instead of -1 from hash_table getBytes()
Compare 2 commits »
andrew closed issue weaselab/conflict-set#62 2026-07-08 13:58:48 +00:00
hash_table implementation returns -1 from getBytes(), violating the API contract
andrew merged pull request weaselab/conflict-set#63 2026-07-08 13:58:48 +00:00
Return 0 instead of -1 from hash_table getBytes()
andrew commented on issue weaselab/conflict-set#62 2026-07-05 04:35:16 +00:00
hash_table implementation returns -1 from getBytes(), violating the API contract

Hash table is test only and does not satisfy the contract. It’s for comparing how fast point ops could be. Returning 0 for bytes used seems ok too

andrew deleted branch weaselbot/issue-5 from weaselbot/weaseldb 2026-06-30 20:36:40 +00:00
andrew pushed to main at weaselab/weaseldb 2026-06-30 20:36:39 +00:00
a053b92911 Add basic Gitea Actions CI workflow (#6)
andrew closed issue weaselab/weaseldb#5 2026-06-30 20:36:39 +00:00
Add some basic CI using gitea actions
andrew merged pull request weaselab/weaseldb#6 2026-06-30 20:36:38 +00:00
Add basic Gitea Actions CI workflow
andrew opened issue weaselab/weaseldb#5 2026-06-30 19:15:35 +00:00
Add some basic CI using gitea actions
andrew deleted branch weaselbot/issue-14 from weaselbot/weaseljson 2026-06-30 16:50:11 +00:00
andrew pushed to main at weaselab/weaseljson 2026-06-30 16:50:09 +00:00
f5ceb392c2 Merge pull request 'schemagen: add regression test for nullable cyclic $ref targets' (#50) from weaselbot/weaseljson:weaselbot/issue-14 into main
be92755cbf schemagen: add regression test for nullable cyclic $ref targets (issue #14)
Compare 2 commits »
andrew closed issue weaselab/weaseljson#14 2026-06-30 16:50:08 +00:00
schemagen drops nullability on cyclic $ref targets
andrew automatically merged pull request weaselab/weaseljson#50 2026-06-30 16:50:08 +00:00