weaselab/conflict-set
2
0
Fork 0
Code Issues 4 Packages Releases 13 Activity

Cachegrind says memset uses fewer instructions here

Browse Source
This commit is contained in:
Andrew Noyes
2024-03-15 16:57:16 -07:00
parent 9d13ca84f5
commit 8556caf360
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ConflictSet.cpp
View File

@@ -447,9 +447,7 @@ inline void Node48::copyChildrenAndKeyFrom(const Node256 &other) {
inline void Node256::copyChildrenAndKeyFrom(const Node48 &other) {
memcpy((char *)this + kNodeCopyBegin, (char *)&other + kNodeCopyBegin,
kNodeCopySize);
for (int i = 0; i < 256; ++i) {
children[i].child = nullptr;
}
memset(children, 0, sizeof(children));
bitSet = other.bitSet;
bitSet.forEachInRange(
[&](int c) {
@@ -464,9 +462,7 @@ inline void Node256::copyChildrenAndKeyFrom(const Node48 &other) {
inline void Node256::copyChildrenAndKeyFrom(const Node256 &other) {
memcpy((char *)this + kNodeCopyBegin, (char *)&other + kNodeCopyBegin,
kNodeCopySize);
for (int i = 0; i < 256; ++i) {
children[i].child = nullptr;
}
memset(children, 0, sizeof(children));
bitSet = other.bitSet;
bitSet.forEachInRange(
[&](int c) {