Get back to 100% line coverage locally
All checks were successful
Tests / Clang total: 1479, passed: 1479
Clang |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Tests / Debug total: 1477, passed: 1477
Tests / SIMD fallback total: 1479, passed: 1479
Tests / Release [gcc] total: 1479, passed: 1479
GNU C Compiler (gcc) |Total|New|Outstanding|Fixed|Trend |:-:|:-:|:-:|:-:|:-: |0|0|0|0|:clap:
Tests / Release [gcc,aarch64] total: 1102, passed: 1102
Tests / Coverage total: 1111, passed: 1111
Code Coverage #### Project Overview No changes detected, that affect the code coverage. * Line Coverage: 99.37% (1744/1755) * Branch Coverage: 64.31% (1512/2351) * Complexity Density: 0.00 * Lines of Code: 1755 #### Quality Gates Summary Output truncated.
weaselab/conflict-set/pipeline/head This commit looks good

This commit is contained in:
2024-08-01 15:31:38 -07:00
parent 3898cb596a
commit ca804f28c0

View File

@@ -1969,6 +1969,9 @@ downLeftSpine:
return n->entry.rangeVersion <= readVersion;
}
// Only one of these is ever exercised. I'm not worried about somehow not
// calling one of these though.
// GCOVR_EXCL_START
#ifdef HAS_AVX
uint32_t compare16_32bit(const InternalVersionT *vs, InternalVersionT rv) {
uint32_t compared = 0;
@@ -1995,6 +1998,7 @@ compare16_32bit_avx512(const InternalVersionT *vs, InternalVersionT rv) {
_mm512_setzero_epi32());
}
#endif
// GCOVR_EXCL_STOP
// Returns true if v[i] <= readVersion for all i such that begin <= is[i] < end
// Preconditions: begin <= end, end - begin < 256
@@ -2049,9 +2053,9 @@ bool scan16(const InternalVersionT *vs, const uint8_t *is, int begin, int end,
uint32_t compared = 0;
if constexpr (kAVX512) {
compared = compare16_32bit_avx512(vs, readVersion);
compared = compare16_32bit_avx512(vs, readVersion); // GCOVR_EXCL_LINE
} else {
compared = compare16_32bit(vs, readVersion);
compared = compare16_32bit(vs, readVersion); // GCOVR_EXCL_LINE
}
return !(compared & mask);
@@ -2077,10 +2081,11 @@ bool scan16(const InternalVersionT *vs, const uint8_t *is, int begin, int end,
// Returns true if v[i] <= readVersion for all i such that begin <= i < end
//
// always_inline So that we can optimize when begin or end is a constant.
// gcovr exclude annotation necessary because of always_inline?
template <bool kAVX512>
inline __attribute__((always_inline)) bool
scan16(const InternalVersionT *vs, int begin, int end,
InternalVersionT readVersion) {
scan16(const InternalVersionT *vs, int begin, int end, // GCOVR_EXCL_LINE
InternalVersionT readVersion) { // GCOVR_EXCL_LINE
assert(0 <= begin && begin < 16);
assert(0 <= end && end <= 16);
assert(begin <= end);