Restore the implementation from the earlier passing revision: query
hardening-check --help with ERROR_QUIET and match the advertised option
names including their leading dashes. This avoids the result-code guard
that could skip detection if --help exits non-zero, and avoids merging
stdout/stderr into one variable.
The previous change tried to detect which architecture-specific skip
flags the installed hardening-check binary supports by grepping its
--help output, but it only used that output when the help command
returned exit code 0. Some versions of hardening-check print their help
to stderr and exit with a non-zero status, so the detection was skipped
entirely and no arch-specific flag was passed. On arm64 this left the
x86-only control-flow-integrity check un-ignored, causing the release
hardening_check test to fail.
Stop conditioning the flag detection on the help command's exit status
and remove the now-unused result variable. Also reformat the comment to
satisfy cmake-format.
Fixes pre-commit and release arm64 CI failures for #51.
* ConflictSet.cpp: enable the interleaved read/write path whenever
musttail is available, falling back to the default calling convention
when preserve_none is not supported. This prevents a large block of
compiled-but-dead code from being counted in coverage.
* CMakeLists.txt: detect which arch-specific hardening-check options the
installed hardening-check binary supports, including the newer
hyphenated spellings, so the release test no longer fails with an
unknown option.
* .gitea/workflows/ci.yml: build the coverage job with
-DUSE_SIMD_FALLBACK=ON so AVX512-only functions that cannot execute on
the CI runners are not counted against line coverage.
`ConflictSet(const ConflictSet&)` and `operator=(const ConflictSet&)` were
only deleted for C++11 and later. In C++98/C++03 the compiler implicitly
generated public copy operations, so copying a ConflictSet shared the opaque
`Impl*` and caused a double-free on destruction.
Declare both operations private and leave them undefined when
`__cplusplus <= 199711L`, matching the standard pre-C++11 idiom for
move-only types. Guard the declarations with `defined(__cplusplus)` so
they are not exposed to C90 compilation units.
Closes#48
ConflictSet_check, ConflictSet_addWrites, ConflictSet_setOldestVersion,
and ConflictSet_destroy return void in C, but the Python wrapper left
their ctypes restype at the default c_int. Set restype = None for each
to match the C API contract and avoid undefined behavior from reading
the return register of void functions.
weaselbot
