`ServerBench.cpp` calls `syscall(SYS_perf_event_open, ...)` but did
not include `<sys/syscall.h>`, relying on `<unistd.h>` to transitively
provide the `SYS_*` constants. On toolchains where that does not happen,
the build fails with `SYS_perf_event_open` not declared.
Add the missing include so `server_bench` compiles on any platform that
provides `perf_event_open`.
Resolvesweaselab/conflict-set#41.
Add the missing [Result.COMMIT] / [Result.CONFLICT] assertions so
that the two regression tests actually verify the expected conflict-set
outcome, not just that the calls do not crash.
The custom command that links conflict-set.o depends on
$<TARGET_OBJECTS:conflict-set-object>, but that generator expression
does not create a target-level dependency. With the Unix Makefiles
generator, parallel builds can start building the consuming libraries
before the object library's build rule is available, producing:
gmake[3]: *** No rule to make target
'CMakeFiles/conflict-set-object.dir/ConflictSet.cpp.o', needed by
'conflict-set.o'. Stop.
Add add_dependencies() so that conflict-set and conflict-set-static
cannot build until conflict-set-object has produced its object files.
Closes#47
The user-declared move-assignment operator overwrote `impl` without first
destroying the existing implementation object, leaking all memory and resources
owned by the left-hand side. Self-move-assignment also set `impl` to nullptr,
leaving the object invalid and leaking the old state.
Fix all three implementations (ConflictSet.cpp, SkipList.cpp, HashTable.cpp)
to guard against self-assignment and to destroy/free the old `impl` before
taking ownership of `other.impl`.
ConflictSet_check, ConflictSet_addWrites, ConflictSet_setOldestVersion,
and ConflictSet_destroy return void in C, but the Python wrapper left
their ctypes restype at the default c_int. Set restype = None for each
to match the C API contract and avoid undefined behavior from reading
the return register of void functions.
weaselbotandandrew