Merge pull request 'Set restype=None for void-returning C functions' (#53 ) from weaselbot/conflict-set:weaselbot/issue-46 into main

Reviewed-on: #53
Set restype=None for void-returning C functions in conflict_set.py
2026-06-22 01:12:47 +00:00 · 2026-06-21 19:25:27 -04:00
1 changed files with 4 additions and 0 deletions
@@ -88,6 +88,7 @@ class ConflictSet:
            ctypes.POINTER(ctypes.c_int),
            ctypes.c_int,
        )
        self._lib.ConflictSet_check.restype = None
        self._lib.ConflictSet_addWrites.argtypes = (
            ctypes.c_void_p,
@@ -95,13 +96,16 @@ class ConflictSet:
            ctypes.c_int,
            ctypes.c_int64,
        )
        self._lib.ConflictSet_addWrites.restype = None
        self._lib.ConflictSet_setOldestVersion.argtypes = (
            ctypes.c_void_p,
            ctypes.c_int64,
        )
        self._lib.ConflictSet_setOldestVersion.restype = None
        self._lib.ConflictSet_destroy.argtypes = (ctypes.c_void_p,)
        self._lib.ConflictSet_destroy.restype = None
        self._lib.ConflictSet_getBytes.argtypes = (ctypes.c_void_p,)
        self._lib.ConflictSet_getBytes.restype = ctypes.c_int64
Author	SHA1	Message	Date
andrew	d70e6a2455	Merge pull request 'Set restype=None for void-returning C functions' (#53 ) from weaselbot/conflict-set:weaselbot/issue-46 into main CI / release (arm64, ubuntu-latest-arm64) (push) Failing after 11m28s Details CI / pre-commit (push) Successful in 2m5s Details CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (push) Successful in 3m37s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (push) Successful in 3m29s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (push) Successful in 3m38s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (push) Successful in 3m28s Details CI / release (amd64, ubuntu-latest-amd64) (push) Successful in 5m3s Details CI / coverage (push) Failing after 3m31s Details Reviewed-on: #53	2026-06-22 01:12:47 +00:00
weaselbot	742d920aa1	Set restype=None for void-returning C functions in conflict_set.py CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m28s Details CI / pre-commit (pull_request) Successful in 2m14s Details CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m39s Details CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m33s Details CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m44s Details CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m32s Details CI / release (amd64, ubuntu-latest-amd64) (pull_request) Failing after 4m25s Details CI / coverage (pull_request) Failing after 3m20s Details ConflictSet_check, ConflictSet_addWrites, ConflictSet_setOldestVersion, and ConflictSet_destroy return void in C, but the Python wrapper left their ctypes restype at the default c_int. Set restype = None for each to match the C API contract and avoid undefined behavior from reading the return register of void functions.	2026-06-21 19:25:27 -04:00