weaselab/conflict-set
1
Fork 1
Code Issues 5 Pull Requests Actions 1 Packages Releases 13 Activity

Keep Python wrapper key buffers alive in WriteRange/ReadRange #43

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-42 into main 2026-06-23 01:17:46 +00:00
Conversation 1 Commits 1 Files Changed 2
+59 -9
weaselbot commented 2026-06-19 17:03:31 +00:00
Member
Copy Link
Copy Source

Closes #42

Closes #42
andrew force-pushed weaselbot/issue-42 from 045bf9b5ef to 3e28538a15 2026-06-21 23:30:16 +00:00 Compare
andrew added 1 commit 2026-06-22 18:09:24 +00:00
Keep Python key buffers alive in WriteRange/ReadRange
CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m22s
Details
CI / pre-commit (pull_request) Successful in 2m5s
Details
CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 3m38s
Details
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 3m32s
Details
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 3m40s
Details
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 3m28s
Details
CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 4m53s
Details
CI / coverage (pull_request) Successful in 3m40s
Details
971deb477c 
`write()` and `read()` created _Key objects from ephemeral ctypes arrays
backed by local bytearray objects. Once the helpers returned, those local
variables were freed, leaving the C library with dangling pointers when
addWrites()/check() later read the keys.

Store the backing bytearray on the returned WriteRange/ReadRange objects
as private `_begin_buf` / `_end_buf` attributes. Python keeps them alive
for the lifetime of the range object, so the C pointer is always valid.

Closes #42
andrew force-pushed weaselbot/issue-42 from 3e28538a15 to 971deb477c 2026-06-22 18:09:24 +00:00 Compare
andrew approved these changes 2026-06-23 01:17:34 +00:00
andrew left a comment
Owner
Copy Link
Copy Source

I don't think this can actually crash, but we'll merge it so weaselbot doesn't open it again

I don't think this can actually crash, but we'll merge it so weaselbot doesn't open it again
andrew merged commit 8f9f345c64 into main 2026-06-23 01:17:46 +00:00
andrew deleted branch weaselbot/issue-42 2026-06-23 01:17:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
andrew
Labels
Clear labels
bug
Something is not working
 enhancement
New feature
 investigation
wontfix
This won't be fixed
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
andrew weaselbot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#43