weaselab/conflict-set
1
Fork 1
Code Issues 5 Pull Requests Actions 1 Packages Releases 13 Activity

Return 0 instead of -1 from hash_table getBytes() #63

Merged
andrew merged 1 commits from weaselbot/conflict-set:weaselbot/issue-62 into main 2026-07-08 13:58:47 +00:00
Conversation 0 Commits 1 Files Changed 3
+23 -5
weaselbot commented 2026-07-07 15:01:00 +00:00
Member
Copy Link
Copy Source

Closes #62

Closes #62
weaselbot added 1 commit 2026-07-07 15:01:01 +00:00
Return 0 instead of -1 from hash_table getBytes()
CI / release (arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m25s
Details
CI / pre-commit (pull_request) Successful in 3m40s
Details
CI / test (-DCMAKE_BUILD_TYPE=Debug, debug) (pull_request) Successful in 5m8s
Details
CI / test (-DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 64-bit-versions) (pull_request) Successful in 4m50s
Details
CI / test (-DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, gcc) (pull_request) Successful in 4m57s
Details
CI / test (-DUSE_SIMD_FALLBACK=ON, simd-fallback) (pull_request) Successful in 4m42s
Details
CI / release (amd64, ubuntu-latest-amd64) (pull_request) Successful in 6m31s
Details
CI / coverage (pull_request) Successful in 4m51s
Details
dee3a8f640 
The hash_table implementation cannot accurately track memory usage and was
returning -1 from ConflictSet::getBytes() and ConflictSet_getBytes(). That
violates the API contract that getBytes() returns a non-negative byte count.

Change both entry points to return 0 and document in ConflictSet.h that
implementations which do not track memory usage may return 0.

Add a regression test in test_conflict_set.py that loads the hash_table
implementation and verifies getBytes() is non-negative.

Closes #62
andrew merged commit d479f16204 into main 2026-07-08 13:58:47 +00:00
andrew deleted branch weaselbot/issue-62 2026-07-08 13:58:48 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 enhancement
New feature
 investigation
wontfix
This won't be fixed
missing-test-coverage
Issues having to do with missing test coverage
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
andrew weaselbot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weaselab/conflict-set#63