weaselab/conflict-set

Fork 1

Replace test_fixup_256 with a regression test for the Node256 fixupMaxVersion false-Commit bug #90

Merged

andrew merged 2 commits from weaselbot/conflict-set:weaselbot/issue-89 into main

2026-10-27 19:33:19 +00:00

Author	SHA1	Message	Date
weaselbot	c94e9aaee6	Remove test_fixup_256, which cannot detect the bug CI / test (arm64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 22, https://minio.weaselab.dev/public/aarch64/msan-toolchain-22.1.8.tar.zst, debug-arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m43s Details CI / release (arm64, , ubuntu-latest-arm64) (pull_request) Successful in 3m24s Details CI / pre-commit (pull_request) Successful in 2m24s Details CI / test (amd64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 21, https://minio.weaselab.dev/public/x86_64/msan-toolchain-21.1.8.tar.zst, debug, ubuntu-latest-amd64) (pull_request) Successful in 4m12s Details CI / test (amd64, -DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 21, , 64-bit-versions, ubuntu-latest-amd64) (pull_request) Successful in 3m28s Details CI / test (amd64, -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, 21, , gcc, ubuntu-latest-amd64) (pull_request) Successful in 7m40s Details CI / test (amd64, -DUSE_SIMD_FALLBACK=ON, 21, , simd-fallback, ubuntu-latest-amd64) (pull_request) Successful in 4m14s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (pull_request) Successful in 7m11s Details CI / coverage (pull_request) Successful in 3m57s Details Every child of the Node256 in test_fixup_256 is written at the same version, so max(childMaxVersion[0..15]) and max(maxOfMax) agree and the buggy code passes. test_fixup_256_heterogeneous_versions covers the same Node256-under-a-range-end shape with distinct versions, so keep only that.	2026-10-27 14:10:36 -04:00
weaselbot	3d3184ef5f	Add regression test for Node256 fixupMaxVersion CI / pre-commit (pull_request) Successful in 2m37s Details CI / test (arm64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 22, https://minio.weaselab.dev/public/aarch64/msan-toolchain-22.1.8.tar.zst, debug-arm64, ubuntu-latest-arm64) (pull_request) Successful in 3m53s Details CI / test (amd64, -DCMAKE_BUILD_TYPE=Debug -DMSAN_TOOLCHAIN_PATH=/opt/msan, 21, https://minio.weaselab.dev/public/x86_64/msan-toolchain-21.1.8.tar.zst, debug, ubuntu-latest-amd64) (pull_request) Successful in 3m51s Details CI / release (arm64, , ubuntu-latest-arm64) (pull_request) Successful in 3m31s Details CI / test (amd64, -DCMAKE_CXX_FLAGS=-DUSE_64_BIT=1, 21, , 64-bit-versions, ubuntu-latest-amd64) (pull_request) Successful in 3m26s Details CI / test (amd64, -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++, 21, , gcc, ubuntu-latest-amd64) (pull_request) Successful in 3m17s Details CI / test (amd64, -DUSE_SIMD_FALLBACK=ON, 21, , simd-fallback, ubuntu-latest-amd64) (pull_request) Successful in 3m25s Details CI / release (amd64, -DMSAN_TOOLCHAIN_PATH=/opt/msan, ubuntu-latest-amd64) (pull_request) Successful in 6m3s Details CI / coverage (pull_request) Successful in 3m50s Details	2026-10-26 18:20:37 -04:00